[jit] Fix ScriptModule.__dir__()
#22426
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`_method_names` is on `_c`, so `dir(script_module)` calls previously didn't work
jamesr66a
approved these changes
Jul 1, 2019
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@driazati is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
xzhu1900
pushed a commit
to xzhu1900/pytorch
that referenced
this pull request
Jul 5, 2019
Summary: `_method_names` is on `_c`, so `dir(script_module)` calls previously didn't work Pull Request resolved: pytorch#22426 Differential Revision: D16085330 Pulled By: driazati fbshipit-source-id: 6f9f1bef5da4306c0f26aa0be1bcec6dd3a6f0fb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_method_namesis on_c, sodir(script_module)calls previouslydidn't work