Manual revert of D16012838 #22412
Closed
Manual revert of D16012838 #22412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytorchbot
added
oncall: jit
Collaborator
|
@ailzhang fyi could impact XLA |
houseroad
reviewed
Jul 1, 2019
Member
houseroad
left a comment
houseroad
left a comment
There was a problem hiding this comment.
This also affects ONNX tests I think
wanchaol
force-pushed
the
export-D16079809
branch
from
1ea6fe7 to
81d3b97
Compare
wanchaol
force-pushed
the
export-D16079809
branch
from
81d3b97 to
af1c397
Compare
Summary: Pull Request resolved: pytorch#22412 Reviewed By: nairbv, houseroad Differential Revision: D16079809 fbshipit-source-id: d51554755ec8e7cabaf0b88d7122500dcd53b735
wanchaol
force-pushed
the
export-D16079809
branch
from
af1c397 to
02296af
Compare
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jul 2, 2019
Summary: Pull Request resolved: pytorch/pytorch#22412 Reviewed By: nairbv, houseroad Differential Revision: D16079809 fbshipit-source-id: ee0d805ff7a2bc5f98bcc65f90b8199751c840f6
Contributor
|
This pull request has been merged in dff2c07. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 4, 2019
… D16079809 (#22456) Summary: re-apply changes reverted in: #22412 Also change log_softmax to take positional arguments. Long-term we do want the kwarg-only interface, but seems to currently be incompatible with jit serialization. Pull Request resolved: #22456 Differential Revision: D16097159 Pulled By: nairbv fbshipit-source-id: 8cb73e9ca18fc66b35b873cf4a574b167a578b3d
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jul 4, 2019
… D16079809 (#22456) Summary: re-apply changes reverted in: pytorch/pytorch#22412 Also change log_softmax to take positional arguments. Long-term we do want the kwarg-only interface, but seems to currently be incompatible with jit serialization. Pull Request resolved: pytorch/pytorch#22456 Differential Revision: D16097159 Pulled By: nairbv fbshipit-source-id: 8cb73e9ca18fc66b35b873cf4a574b167a578b3d
xzhu1900
pushed a commit
to xzhu1900/pytorch
that referenced
this pull request
Jul 5, 2019
Summary: Pull Request resolved: pytorch#22412 Reviewed By: nairbv, houseroad Differential Revision: D16079809 fbshipit-source-id: ee0d805ff7a2bc5f98bcc65f90b8199751c840f6
xzhu1900
pushed a commit
to xzhu1900/pytorch
that referenced
this pull request
Jul 5, 2019
… D16079809 (pytorch#22456) Summary: re-apply changes reverted in: pytorch#22412 Also change log_softmax to take positional arguments. Long-term we do want the kwarg-only interface, but seems to currently be incompatible with jit serialization. Pull Request resolved: pytorch#22456 Differential Revision: D16097159 Pulled By: nairbv fbshipit-source-id: 8cb73e9ca18fc66b35b873cf4a574b167a578b3d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D16079809