Delegate Python ~ (invert operator) to Tensor.bitwise_not(). #22326

xuhdev · 2019-06-28T00:04:57Z

Stack from ghstack:

Delegate Python ~ (invert operator) to Tensor.bitwise_not(). #22326 Delegate Python ~ (invert operator) to Tensor.bitwise_not().
Add a bitwise NOT operator for integer and Boolean types (CUDA). #22320 Add a bitwise NOT operator for integer and Boolean types (CUDA).
Add a bitwise NOT operator for integer and Boolean types (CPU). #22283 Add a bitwise NOT operator for integer and Boolean types (CPU).

Close #20024, Close #22246, Close #22262

Differential Revision: D16183577

Close #20024, Close #22246, Close #22262 Related #22324

Delegate Python ~ (invert operator) to Tensor.bitwise_not(). Close #20024, Close #22246, Close #22262 Related #22324 gh-metadata: pytorch pytorch 22326 gh/xuhdev/8/head

xuhdev · 2019-06-28T07:24:02Z

This commit changes the ~ operator from being a simple 1-self to have a bitwise NOT functionality, because it is usually understood so in Python. Indeed, two mentioned issues, #22246 and #22324, (mis-)understand this operator as a "bitwise" operator.

Previously, as discussed in #4082, ~ was kept as 1-self because ByteTensor was playing double duty of uint8 and bool. Given that we have BoolTensor now, do you think it is time to make the switch? @apaszke @colesbury

apaszke · 2019-06-30T14:55:42Z

tools/autograd/templates/python_variable_methods.cpp

  auto& self_ = reinterpret_cast<THPVariable*>(self)->cdata;
-  if (self_.scalar_type() != at::kByte) {
-    throw TypeError("~ (operator.invert) is only implemented on byte tensors");
+  if (!isIntegralType(self_.scalar_type()) && self_.scalar_type() != at::kBool) {


Why isn't bool an integral type? It's not different than uint1

It's defined here. It's probably worth another independent PR for discussing it...

It looks like current usage and definition of isIntegralType are more of semantic sense (bool is technically integral, but semantically it is not used as an integer). I would lean toward keep it as it is now.

Examples:

pytorch/aten/src/ATen/native/cpu/BinaryOpsKernel.cpp

Line 43 in cca923c

if (isIntegralType(iter.dtype())) {

pytorch/torch/csrc/autograd/python_variable_indexing.cpp

Line 171 in cca923c

if (var.dim() == 0 && at::isIntegralType(scalar_type)) {

test/test_torch.py

Delegate Python ~ (invert operator) to Tensor.bitwise_not(). Close #20024, Close #22246, Close #22262 Related #22324 gh-metadata: pytorch pytorch 22326 gh/xuhdev/8/head

xuhdev · 2019-06-30T21:57:05Z

@pytorchbot retest this please

xuhdev · 2019-07-01T04:03:29Z

@pytorchbot retest this please

test/test_torch.py

Delegate Python ~ (invert operator) to Tensor.bitwise_not(). Close #20024, Close #22246, Close #22262 Related #22324 gh-metadata: pytorch pytorch 22326 gh/xuhdev/8/head

colesbury · 2019-07-09T17:12:51Z

@xuhdev is this stack of PRs ready?

xuhdev · 2019-07-09T17:52:27Z

@colesbury Yes.

xuhdev · 2019-07-10T17:46:10Z

@pytorchbot merge this please

facebook-github-bot · 2019-07-10T22:04:23Z

@colesbury merged this pull request in 9c4c9c3.

colesbury · 2019-07-11T00:34:17Z

I'm reverting this for now. The problem is that comparison operators still return torch.uint8 and now ~ behaves differently. Once comparison operators return torch.bool we can re-land this

Delegate Python ~ (invert operator) to Tensor.bitwise_not().

d9e6676

Close #20024, Close #22246, Close #22262 Related #22324

pytorchbot added module: internals Related to internal abstractions in c10 and ATen module: operators module: pybind Related to our Python bindings / interactions with other Python libraries labels Jun 28, 2019

This was referenced Jun 28, 2019

Add a bitwise NOT operator for integer and Boolean types (CPU). #22283

Closed

Add a bitwise NOT operator for integer and Boolean types (CUDA). #22320

Closed

xuhdev requested review from colesbury and izdeby June 28, 2019 00:05

ezyang added the open source label Jun 28, 2019

li-roy added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jun 28, 2019

Update on "Delegate Python ~ (invert operator) to Tensor.bitwise_not()."

d44e96b

Delegate Python ~ (invert operator) to Tensor.bitwise_not(). Close #20024, Close #22246, Close #22262 Related #22324 gh-metadata: pytorch pytorch 22326 gh/xuhdev/8/head

apaszke reviewed Jun 30, 2019

View reviewed changes

xuhdev added 2 commits June 30, 2019 09:23

Update on "Delegate Python ~ (invert operator) to Tensor.bitwise_not()."

6b040dd

Delegate Python ~ (invert operator) to Tensor.bitwise_not(). Close #20024, Close #22246, Close #22262 Related #22324 gh-metadata: pytorch pytorch 22326 gh/xuhdev/8/head

Update on "Delegate Python ~ (invert operator) to Tensor.bitwise_not()."

0f0faf5

Delegate Python ~ (invert operator) to Tensor.bitwise_not(). Close #20024, Close #22246, Close #22262 Related #22324 gh-metadata: pytorch pytorch 22326 gh/xuhdev/8/head

xuhdev requested a review from apaszke June 30, 2019 16:25

colesbury requested changes Jul 1, 2019

View reviewed changes

test/test_torch.py Outdated Show resolved Hide resolved

test/test_torch.py Outdated Show resolved Hide resolved

xuhdev added 3 commits July 1, 2019 13:04

Update on "Delegate Python ~ (invert operator) to Tensor.bitwise_not()."

8b481cf

Delegate Python ~ (invert operator) to Tensor.bitwise_not(). Close #20024, Close #22246, Close #22262 Related #22324 gh-metadata: pytorch pytorch 22326 gh/xuhdev/8/head

Update on "Delegate Python ~ (invert operator) to Tensor.bitwise_not()."

4b89b53

Delegate Python ~ (invert operator) to Tensor.bitwise_not(). Close #20024, Close #22246, Close #22262 Related #22324 gh-metadata: pytorch pytorch 22326 gh/xuhdev/8/head

Update on "Delegate Python ~ (invert operator) to Tensor.bitwise_not()."

857ab08

Delegate Python ~ (invert operator) to Tensor.bitwise_not(). Close #20024, Close #22246, Close #22262 Related #22324 gh-metadata: pytorch pytorch 22326 gh/xuhdev/8/head

xuhdev requested a review from colesbury July 1, 2019 22:25

xuhdev added 7 commits July 1, 2019 15:27

Update on "Delegate Python ~ (invert operator) to Tensor.bitwise_not()."

1f44c8a

Delegate Python ~ (invert operator) to Tensor.bitwise_not(). Close #20024, Close #22246, Close #22262 Related #22324 gh-metadata: pytorch pytorch 22326 gh/xuhdev/8/head

Update on "Delegate Python ~ (invert operator) to Tensor.bitwise_not()."

5169fc1

Delegate Python ~ (invert operator) to Tensor.bitwise_not(). Close #20024, Close #22246, Close #22262 Related #22324 gh-metadata: pytorch pytorch 22326 gh/xuhdev/8/head

Update on "Delegate Python ~ (invert operator) to Tensor.bitwise_not()."

41f573b

Delegate Python ~ (invert operator) to Tensor.bitwise_not(). Close #20024, Close #22246, Close #22262 Related #22324 gh-metadata: pytorch pytorch 22326 gh/xuhdev/8/head

Update on "Delegate Python ~ (invert operator) to Tensor.bitwise_not()."

3bd7095

Delegate Python ~ (invert operator) to Tensor.bitwise_not(). Close #20024, Close #22246, Close #22262 Related #22324 gh-metadata: pytorch pytorch 22326 gh/xuhdev/8/head

Update on "Delegate Python ~ (invert operator) to Tensor.bitwise_not()."

8747935

Delegate Python ~ (invert operator) to Tensor.bitwise_not(). Close #20024, Close #22246, Close #22262 Related #22324 gh-metadata: pytorch pytorch 22326 gh/xuhdev/8/head

Update on "Delegate Python ~ (invert operator) to Tensor.bitwise_not()."

c7587af

Delegate Python ~ (invert operator) to Tensor.bitwise_not(). Close #20024, Close #22246, Close #22262 Related #22324 gh-metadata: pytorch pytorch 22326 gh/xuhdev/8/head

Update on "Delegate Python ~ (invert operator) to Tensor.bitwise_not()."

b75edc7

Delegate Python ~ (invert operator) to Tensor.bitwise_not(). Close #20024, Close #22246, Close #22262 Related #22324 gh-metadata: pytorch pytorch 22326 gh/xuhdev/8/head

xuhdev added 4 commits July 2, 2019 20:24

Update on "Delegate Python ~ (invert operator) to Tensor.bitwise_not()."

fd68eb6

Delegate Python ~ (invert operator) to Tensor.bitwise_not(). Close #20024, Close #22246, Close #22262 Related #22324 gh-metadata: pytorch pytorch 22326 gh/xuhdev/8/head

Update on "Delegate Python ~ (invert operator) to Tensor.bitwise_not()."

df30999

Delegate Python ~ (invert operator) to Tensor.bitwise_not(). Close #20024, Close #22246, Close #22262 Related #22324 gh-metadata: pytorch pytorch 22326 gh/xuhdev/8/head

Update on "Delegate Python ~ (invert operator) to Tensor.bitwise_not()."

1dd4705

Delegate Python ~ (invert operator) to Tensor.bitwise_not(). Close #20024, Close #22246, Close #22262 Related #22324 gh-metadata: pytorch pytorch 22326 gh/xuhdev/8/head

Update on "Delegate Python ~ (invert operator) to Tensor.bitwise_not()."

4b91cdf

Delegate Python ~ (invert operator) to Tensor.bitwise_not(). Close #20024, Close #22246, Close #22262 Related #22324 gh-metadata: pytorch pytorch 22326 gh/xuhdev/8/head

colesbury approved these changes Jul 10, 2019

View reviewed changes

pytorchbot added the merge-this-please Was marked for merge with @pytorchbot merge this please label Jul 10, 2019

facebook-github-bot closed this in 9c4c9c3 Jul 10, 2019

xuhdev deleted the gh/xuhdev/8/head branch July 10, 2019 19:25

facebook-github-bot added the merged label Jul 10, 2019

colesbury mentioned this pull request Jul 11, 2019

[BC-BREAKING] Changed tensor comparison return type from uint8 to bool #21113

Closed

This was referenced Jul 13, 2019

New 'bool' type doesn't support inversion in 1.1.0 #20024

Closed

[feature request] Inplace bitwise negation operator #22246

Closed

Why is THPVariable_invert implemented on the python level and not c++ #22262

Closed

gchanan mentioned this pull request Jul 15, 2019

Ensure invert operator change gets into 1.2 #22871

Closed

gchanan added the module: bc-breaking Related to a BC-breaking change label Aug 2, 2019

mruberry added the Merged label Oct 28, 2020

Delegate Python ~ (invert operator) to Tensor.bitwise_not(). #22326

Delegate Python ~ (invert operator) to Tensor.bitwise_not(). #22326

Uh oh!

Conversation

xuhdev commented Jun 28, 2019 • edited by colesbury Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xuhdev commented Jun 28, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

apaszke Jun 30, 2019

Choose a reason for hiding this comment

Uh oh!

xuhdev Jun 30, 2019

Choose a reason for hiding this comment

Uh oh!

xuhdev Jun 30, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

xuhdev commented Jun 30, 2019

Uh oh!

xuhdev commented Jul 1, 2019

Uh oh!

Uh oh!

Uh oh!

colesbury commented Jul 9, 2019

Uh oh!

xuhdev commented Jul 9, 2019

Uh oh!

xuhdev commented Jul 10, 2019

Uh oh!

facebook-github-bot commented Jul 10, 2019

Uh oh!

colesbury commented Jul 11, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

xuhdev commented Jun 28, 2019 •

edited by colesbury

Loading

xuhdev commented Jun 28, 2019 •

edited

Loading