Skip to content

Added invert bitwise operation to JIT #22324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Chillee wants to merge 8 commits into from
Closed

Added invert bitwise operation to JIT #22324

Chillee wants to merge 8 commits into from

Conversation

@Chillee
Copy link
Collaborator

@Chillee Chillee commented Jun 27, 2019 •
edited
Loading

Fixes #25360
Fixes part of #22124

@pytorchbot pytorchbot added oncall: jit Add this issue/PR to JIT oncall triage queue module: internals Related to internal abstractions in c10 and ATen labels Jun 27, 2019
@Chillee
Copy link
Collaborator Author

Chillee commented Jun 27, 2019

Oh whups, it seems like this is already being done (in the correct way here): #22320

:'(

@Chillee Chillee closed this Jun 27, 2019
@Chillee
Copy link
Collaborator Author

Chillee commented Jun 27, 2019 •
edited
Loading

Actually, it doesn't change that much about this PR - I'll keep this open. It is blocked on it though.

@Chillee Chillee reopened this Jun 27, 2019
@xuhdev xuhdev mentioned this pull request Jun 28, 2019
Closed
xuhdev added a commit that referenced this pull request Jun 28, 2019
@xuhdev
Delegate Python ~ (invert operator) to Tensor.bitwise_not().
d9e6676 
Close #20024, Close #22246, Close #22262

Related #22324
xuhdev added a commit that referenced this pull request Jun 28, 2019
@xuhdev
Update on "Delegate Python ~ (invert operator) to Tensor.bitwise_not()."
d44e96b 
Delegate Python ~ (invert operator) to Tensor.bitwise_not().

Close #20024, Close #22246, Close #22262

Related #22324

gh-metadata: pytorch pytorch 22326 gh/xuhdev/8/head
xuhdev added a commit that referenced this pull request Jun 28, 2019
@xuhdev
Delegate Python ~ (invert operator) to Tensor.bitwise_not().
a2e5c59 
Close #20024, Close #22246, Close #22262

Related #22324

gh-metadata: pytorch pytorch 22326 gh/xuhdev/8/head
xuhdev added a commit that referenced this pull request Jun 30, 2019
@xuhdev
Update on "Delegate Python ~ (invert operator) to Tensor.bitwise_not()."
0f0faf5 
Delegate Python ~ (invert operator) to Tensor.bitwise_not().

Close #20024, Close #22246, Close #22262

Related #22324

gh-metadata: pytorch pytorch 22326 gh/xuhdev/8/head
xuhdev added a commit that referenced this pull request Jun 30, 2019
@xuhdev
Delegate Python ~ (invert operator) to Tensor.bitwise_not().
bf4280e 
Close #20024, Close #22246, Close #22262

Related #22324

gh-metadata: pytorch pytorch 22326 gh/xuhdev/8/head
xuhdev added a commit that referenced this pull request Jul 1, 2019
@xuhdev
Delegate Python ~ (invert operator) to Tensor.bitwise_not().
8f6fe1a 
Close #20024, Close #22246, Close #22262

Related #22324

gh-metadata: pytorch pytorch 22326 gh/xuhdev/8/head
xuhdev added a commit that referenced this pull request Jul 1, 2019
@xuhdev
Update on "Delegate Python ~ (invert operator) to Tensor.bitwise_not()."
8b481cf 
Delegate Python ~ (invert operator) to Tensor.bitwise_not().

Close #20024, Close #22246, Close #22262

Related #22324

gh-metadata: pytorch pytorch 22326 gh/xuhdev/8/head
xuhdev added a commit that referenced this pull request Jul 1, 2019
@xuhdev
Update on "Delegate Python ~ (invert operator) to Tensor.bitwise_not()."
4b89b53 
Delegate Python ~ (invert operator) to Tensor.bitwise_not().

Close #20024, Close #22246, Close #22262

Related #22324

gh-metadata: pytorch pytorch 22326 gh/xuhdev/8/head
xuhdev added a commit that referenced this pull request Jul 1, 2019
@xuhdev
Update on "Delegate Python ~ (invert operator) to Tensor.bitwise_not()."
857ab08 
Delegate Python ~ (invert operator) to Tensor.bitwise_not().

Close #20024, Close #22246, Close #22262

Related #22324

gh-metadata: pytorch pytorch 22326 gh/xuhdev/8/head
xuhdev added a commit that referenced this pull request Jul 1, 2019
@xuhdev
Update on "Delegate Python ~ (invert operator) to Tensor.bitwise_not()."
1f44c8a 
Delegate Python ~ (invert operator) to Tensor.bitwise_not().

Close #20024, Close #22246, Close #22262

Related #22324

gh-metadata: pytorch pytorch 22326 gh/xuhdev/8/head
xuhdev added a commit that referenced this pull request Jul 2, 2019
@xuhdev
Update on "Delegate Python ~ (invert operator) to Tensor.bitwise_not()."
5169fc1 
Delegate Python ~ (invert operator) to Tensor.bitwise_not().

Close #20024, Close #22246, Close #22262

Related #22324

gh-metadata: pytorch pytorch 22326 gh/xuhdev/8/head
xuhdev added a commit that referenced this pull request Jul 2, 2019
@xuhdev
Delegate Python ~ (invert operator) to Tensor.bitwise_not().
879665e 
Close #20024, Close #22246, Close #22262

Related #22324

gh-metadata: pytorch pytorch 22326 gh/xuhdev/8/head
xuhdev added a commit that referenced this pull request Jul 2, 2019
@xuhdev
Update on "Delegate Python ~ (invert operator) to Tensor.bitwise_not()."
41f573b 
Delegate Python ~ (invert operator) to Tensor.bitwise_not().

Close #20024, Close #22246, Close #22262

Related #22324

gh-metadata: pytorch pytorch 22326 gh/xuhdev/8/head
xuhdev added a commit that referenced this pull request Jul 2, 2019
@xuhdev
Update on "Delegate Python ~ (invert operator) to Tensor.bitwise_not()."
3bd7095 
Delegate Python ~ (invert operator) to Tensor.bitwise_not().

Close #20024, Close #22246, Close #22262

Related #22324

gh-metadata: pytorch pytorch 22326 gh/xuhdev/8/head
xuhdev added a commit that referenced this pull request Jul 2, 2019
@xuhdev
Update on "Delegate Python ~ (invert operator) to Tensor.bitwise_not()."
8747935 
Delegate Python ~ (invert operator) to Tensor.bitwise_not().

Close #20024, Close #22246, Close #22262

Related #22324

gh-metadata: pytorch pytorch 22326 gh/xuhdev/8/head
@Chillee Chillee requested review from ailzhang and jamesr66a August 1, 2019 23:57
@Chillee
Copy link
Collaborator Author

Chillee commented Aug 1, 2019

Updated to do it properly (I believe).

@Chillee Chillee requested a review from xuhdev August 6, 2019 21:57
@jerryzh168 jerryzh168 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Aug 12, 2019
@driazati driazati mentioned this pull request Aug 28, 2019
Closed
driazati
driazati approved these changes Aug 28, 2019
View reviewed changes
Copy link
Contributor

@driazati driazati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, still needs a test though. If you want to add it go ahead, if not we can hijack this PR in a couple days and do it ourselves.

@ZolotukhinM
Copy link

ZolotukhinM commented Aug 28, 2019

I believe you are referencing wrong issues in the commit message - the first one (#25069) is an unrelated PR. Please remove the "Fixes" line for it.

@Chillee Chillee requested a review from apaszke as a code owner August 29, 2019 23:17
@Chillee
Copy link
Collaborator Author

Chillee commented Aug 29, 2019

@driazati Added the test, there's some funkiness with self.checkScript and the lexing, so I just used self.assertEqual.

@Chillee
Copy link
Collaborator Author

Chillee commented Aug 30, 2019

@pytorchbot merge this please

facebook-github-bot
facebook-github-bot reviewed Aug 30, 2019
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yf225 is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@Chillee
Copy link
Collaborator Author

Chillee commented Sep 1, 2019

@soumith mentioned that the failing internal test was a flaky test.

@Chillee
Copy link
Collaborator Author

Chillee commented Sep 3, 2019

@pytorchbot merge this please

@pytorchbot pytorchbot added the merge-this-please Was marked for merge with @pytorchbot merge this please label Sep 3, 2019
@xuhdev xuhdev deleted the addinvert branch September 3, 2019 18:16
zdevito pushed a commit to zdevito/ATen that referenced this pull request Sep 3, 2019
@Chillee @facebook-github-bot
Added invert bitwise operation to JIT (#22324)
53a617e 
Summary:
Fixes pytorch/pytorch#25360
Fixes pytorch/pytorch#22124
Pull Request resolved: pytorch/pytorch#22324

Differential Revision: D17140477

Pulled By: yf225

fbshipit-source-id: f42aec5e688fe079d9e79726b7a6c345da94ae2e
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 3, 2019

@yf225 merged this pull request in f3f83cc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@jamesr66a jamesr66a Awaiting requested review from jamesr66a

@ailzhang ailzhang Awaiting requested review from ailzhang

@xuhdev xuhdev Awaiting requested review from xuhdev

@apaszke apaszke Awaiting requested review from apaszke

+1 more reviewer

@driazati driazati driazati approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

merge-this-please Was marked for merge with @pytorchbot merge this please Merged module: internals Related to internal abstractions in c10 and ATen oncall: jit Add this issue/PR to JIT oncall triage queue open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[JIT] JIT frontend uses len(op_token) before checking for None

9 participants

@Chillee @ZolotukhinM @facebook-github-bot @driazati @ezyang @jerryzh168 @pytorchbot @mruberry