Add a bitwise NOT operator for integer and Boolean types (CUDA). #22320

xuhdev · 2019-06-27T22:33:07Z

Stack from ghstack:

Delegate Python ~ (invert operator) to Tensor.bitwise_not(). #22326 Delegate Python ~ (invert operator) to Tensor.bitwise_not().
Add a bitwise NOT operator for integer and Boolean types (CUDA). #22320 Add a bitwise NOT operator for integer and Boolean types (CUDA).
Add a bitwise NOT operator for integer and Boolean types (CPU). #22283 Add a bitwise NOT operator for integer and Boolean types (CPU).

Related to #20024, #22246, #22262

Differential Revision: D16183578

Related to #20024, #22246, #22262

…CUDA)." Add a bitwise NOT operator for integer and Boolean types (CUDA). Related to #20024, #22246, #22262 gh-metadata: pytorch pytorch 22320 gh/xuhdev/7/head

colesbury

This doesn't look like it will work on non-contiguous Tensors. Use TensorIterator here, like you do for the CPU kernel. I think the only difference from the CPU version will be that you should call gpu_kernel instead of cpu_kernel

…CUDA)." Add a bitwise NOT operator for integer and Boolean types (CUDA). Related to #20024, #22246, #22262 gh-metadata: pytorch pytorch 22320 gh/xuhdev/7/head

aten/src/ATen/native/cuda/UnaryOpsKernel.cu

test/test_cuda.py

aten/src/ATen/native/cuda/CUDAUnaryOps.cpp

…CUDA)." Add a bitwise NOT operator for integer and Boolean types (CUDA). Related to #20024, #22246, #22262 gh-metadata: pytorch pytorch 22320 gh/xuhdev/7/head

VitalyFedyunin · 2019-07-03T21:48:34Z

aten/src/ATen/native/native_functions.yaml

 - func: bitwise_not(Tensor self, *, Tensor(a!) out) -> Tensor(a!)
  dispatch:
-    CPU: _bitwise_not_out_cpu
+    CPU: bitwise_not_out


No need to list them if the dispatch to the same function.

There are other places like this, e.g.

pytorch/aten/src/ATen/native/native_functions.yaml

Lines 2753 to 2754 in d9e15bc

CPU: dense_to_sparse

CUDA: dense_to_sparse

where CPU and CUDA dispatches go to the same functions - I assumed this is so that sparse tensors error out with a nice message if they call this function? If that's the case, makes sense to leave it here too.

…CUDA)." Add a bitwise NOT operator for integer and Boolean types (CUDA). Related to #20024, #22246, #22262 gh-metadata: pytorch pytorch 22320 gh/xuhdev/7/head

Summary: Pull Request resolved: pytorch/pytorch#22320 Test Plan: Imported from OSS Differential Revision: D16183578 Pulled By: colesbury fbshipit-source-id: 2f72cce5e10fd637be1ac87e1bbfe0937a661034

facebook-github-bot · 2019-07-10T22:04:21Z

@colesbury merged this pull request in 574e808.

Add a bitwise NOT operator for integer and Boolean types (CUDA).

1a8e29a

Related to #20024, #22246, #22262

pytorchbot added module: cuda Related to torch.cuda, and CUDA support in general module: operators labels Jun 27, 2019

xuhdev mentioned this pull request Jun 27, 2019

Add a bitwise NOT operator for integer and Boolean types (CPU). #22283

Closed

xuhdev added 2 commits June 27, 2019 15:33

Update on "Add a bitwise NOT operator for integer and Boolean types (…

e7188e4

…CUDA)." Add a bitwise NOT operator for integer and Boolean types (CUDA). Related to #20024, #22246, #22262 gh-metadata: pytorch pytorch 22320 gh/xuhdev/7/head

Update on "Add a bitwise NOT operator for integer and Boolean types (…

10d3816

…CUDA)." Add a bitwise NOT operator for integer and Boolean types (CUDA). Related to #20024, #22246, #22262 gh-metadata: pytorch pytorch 22320 gh/xuhdev/7/head

xuhdev requested a review from izdeby June 27, 2019 22:36

ezyang added the open source label Jun 27, 2019

Update on "Add a bitwise NOT operator for integer and Boolean types (…

20de04d

…CUDA)." Add a bitwise NOT operator for integer and Boolean types (CUDA). Related to #20024, #22246, #22262 gh-metadata: pytorch pytorch 22320 gh/xuhdev/7/head

xuhdev requested a review from colesbury June 27, 2019 22:44

xuhdev added 2 commits June 27, 2019 16:05

Update on "Add a bitwise NOT operator for integer and Boolean types (…

6cde803

…CUDA)." Add a bitwise NOT operator for integer and Boolean types (CUDA). Related to #20024, #22246, #22262 gh-metadata: pytorch pytorch 22320 gh/xuhdev/7/head

Update on "Add a bitwise NOT operator for integer and Boolean types (…

6cf4053

…CUDA)." Add a bitwise NOT operator for integer and Boolean types (CUDA). Related to #20024, #22246, #22262 gh-metadata: pytorch pytorch 22320 gh/xuhdev/7/head

Chillee mentioned this pull request Jun 27, 2019

Added invert bitwise operation to JIT #22324

Closed

xuhdev mentioned this pull request Jun 28, 2019

Delegate Python ~ (invert operator) to Tensor.bitwise_not(). #22326

Closed

li-roy added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jun 28, 2019

xuhdev requested a review from ngimel June 30, 2019 08:21

xuhdev added 2 commits June 30, 2019 09:23

Update on "Add a bitwise NOT operator for integer and Boolean types (…

52aa0fb

…CUDA)." Add a bitwise NOT operator for integer and Boolean types (CUDA). Related to #20024, #22246, #22262 gh-metadata: pytorch pytorch 22320 gh/xuhdev/7/head

Update on "Add a bitwise NOT operator for integer and Boolean types (…

ad0a74b

…CUDA)." Add a bitwise NOT operator for integer and Boolean types (CUDA). Related to #20024, #22246, #22262 gh-metadata: pytorch pytorch 22320 gh/xuhdev/7/head

colesbury requested changes Jul 1, 2019

View reviewed changes

Update on "Add a bitwise NOT operator for integer and Boolean types (…

d76b541

…CUDA)." Add a bitwise NOT operator for integer and Boolean types (CUDA). Related to #20024, #22246, #22262 gh-metadata: pytorch pytorch 22320 gh/xuhdev/7/head

pytorchbot added the module: cpu CPU specific problem (e.g., perf, algorithm) label Jul 1, 2019

Update on "Add a bitwise NOT operator for integer and Boolean types (…

524bce4

…CUDA)." Add a bitwise NOT operator for integer and Boolean types (CUDA). Related to #20024, #22246, #22262 gh-metadata: pytorch pytorch 22320 gh/xuhdev/7/head

xuhdev requested a review from colesbury July 1, 2019 22:24

xuhdev added 2 commits July 1, 2019 15:27

Update on "Add a bitwise NOT operator for integer and Boolean types (…

9ca2457

…CUDA)." Add a bitwise NOT operator for integer and Boolean types (CUDA). Related to #20024, #22246, #22262 gh-metadata: pytorch pytorch 22320 gh/xuhdev/7/head

Update on "Add a bitwise NOT operator for integer and Boolean types (…

9b3472d

…CUDA)." Add a bitwise NOT operator for integer and Boolean types (CUDA). Related to #20024, #22246, #22262 gh-metadata: pytorch pytorch 22320 gh/xuhdev/7/head

colesbury reviewed Jul 2, 2019

View reviewed changes

aten/src/ATen/native/cuda/UnaryOpsKernel.cu Outdated Show resolved Hide resolved

test/test_cuda.py Show resolved Hide resolved

aten/src/ATen/native/cuda/CUDAUnaryOps.cpp Outdated Show resolved Hide resolved

xuhdev added 4 commits July 2, 2019 11:56

Update on "Add a bitwise NOT operator for integer and Boolean types (…

8351b8e

…CUDA)." Add a bitwise NOT operator for integer and Boolean types (CUDA). Related to #20024, #22246, #22262 gh-metadata: pytorch pytorch 22320 gh/xuhdev/7/head

Update on "Add a bitwise NOT operator for integer and Boolean types (…

c03b85e

…CUDA)." Add a bitwise NOT operator for integer and Boolean types (CUDA). Related to #20024, #22246, #22262 gh-metadata: pytorch pytorch 22320 gh/xuhdev/7/head

Update on "Add a bitwise NOT operator for integer and Boolean types (…

1d8b291

…CUDA)." Add a bitwise NOT operator for integer and Boolean types (CUDA). Related to #20024, #22246, #22262 gh-metadata: pytorch pytorch 22320 gh/xuhdev/7/head

Update on "Add a bitwise NOT operator for integer and Boolean types (…

7bd290c

…CUDA)." Add a bitwise NOT operator for integer and Boolean types (CUDA). Related to #20024, #22246, #22262 gh-metadata: pytorch pytorch 22320 gh/xuhdev/7/head

xuhdev requested a review from colesbury July 2, 2019 19:08

xuhdev added 4 commits July 2, 2019 20:23

Update on "Add a bitwise NOT operator for integer and Boolean types (…

7613335

…CUDA)." Add a bitwise NOT operator for integer and Boolean types (CUDA). Related to #20024, #22246, #22262 gh-metadata: pytorch pytorch 22320 gh/xuhdev/7/head

Update on "Add a bitwise NOT operator for integer and Boolean types (…

c7096d4

…CUDA)." Add a bitwise NOT operator for integer and Boolean types (CUDA). Related to #20024, #22246, #22262 gh-metadata: pytorch pytorch 22320 gh/xuhdev/7/head

Update on "Add a bitwise NOT operator for integer and Boolean types (…

4102d18

…CUDA)." Add a bitwise NOT operator for integer and Boolean types (CUDA). Related to #20024, #22246, #22262 gh-metadata: pytorch pytorch 22320 gh/xuhdev/7/head

Update on "Add a bitwise NOT operator for integer and Boolean types (…

31bb406

…CUDA)." Add a bitwise NOT operator for integer and Boolean types (CUDA). Related to #20024, #22246, #22262 gh-metadata: pytorch pytorch 22320 gh/xuhdev/7/head

VitalyFedyunin reviewed Jul 3, 2019

View reviewed changes

Update on "Add a bitwise NOT operator for integer and Boolean types (…

9abde47

…CUDA)." Add a bitwise NOT operator for integer and Boolean types (CUDA). Related to #20024, #22246, #22262 gh-metadata: pytorch pytorch 22320 gh/xuhdev/7/head

colesbury approved these changes Jul 10, 2019

View reviewed changes

facebook-github-bot closed this in 574e808 Jul 10, 2019

zou3519 deleted the gh/xuhdev/7/head branch July 10, 2019 19:20

facebook-github-bot added the merged label Jul 10, 2019

gchanan mentioned this pull request Jul 24, 2019

[BC-BREAKING] Changed tensor comparison return type from uint8 to bool #21113

Closed

mruberry added the Merged label Oct 28, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add a bitwise NOT operator for integer and Boolean types (CUDA). #22320

Add a bitwise NOT operator for integer and Boolean types (CUDA). #22320

Uh oh!

xuhdev commented Jun 27, 2019 •

edited by colesbury

Loading

Uh oh!

colesbury left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

VitalyFedyunin Jul 3, 2019

Uh oh!

ngimel Jul 3, 2019

Uh oh!

facebook-github-bot commented Jul 10, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Add a bitwise NOT operator for integer and Boolean types (CUDA). #22320

Add a bitwise NOT operator for integer and Boolean types (CUDA). #22320

Uh oh!

Conversation

xuhdev commented Jun 27, 2019 • edited by colesbury Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

colesbury left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

VitalyFedyunin Jul 3, 2019

Choose a reason for hiding this comment

Uh oh!

ngimel Jul 3, 2019

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented Jul 10, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

xuhdev commented Jun 27, 2019 •

edited by colesbury

Loading