Add a bitwise NOT operator for integer and Boolean types (CPU). #22283

xuhdev · 2019-06-26T22:29:35Z

Stack from ghstack:

Delegate Python ~ (invert operator) to Tensor.bitwise_not(). #22326 Delegate Python ~ (invert operator) to Tensor.bitwise_not().
Add a bitwise NOT operator for integer and Boolean types (CUDA). #22320 Add a bitwise NOT operator for integer and Boolean types (CUDA).
Add a bitwise NOT operator for integer and Boolean types (CPU). #22283 Add a bitwise NOT operator for integer and Boolean types (CPU).

Related to #20024, #22246, #22262

Differential Revision: D16183576

Related to #20024, #22246, #22262

…CPU)." Add a bitwise NOT operator for integer and Boolean types (CPU). Related to #20024, #22246, #22262 gh-metadata: pytorch pytorch 22283 gh/xuhdev/6/head

xuhdev · 2019-06-27T00:57:22Z

In subsequent PRs, I will implement a GPU version and replace the ~ operator implementation with this function. But this PR by itself can also be seen as an independent contribution.

…CPU)." Add a bitwise NOT operator for integer and Boolean types (CPU). Related to #20024, #22246, #22262 gh-metadata: pytorch pytorch 22283 gh/xuhdev/6/head

aten/src/ATen/native/cpu/UnaryOpsKernel.cpp

test/test_torch.py

torch/_torch_docs.py

…CPU)." Add a bitwise NOT operator for integer and Boolean types (CPU). Related to #20024, #22246, #22262 gh-metadata: pytorch pytorch 22283 gh/xuhdev/6/head

izdeby · 2019-06-27T18:44:51Z

are you going to add support for CUDA?

xuhdev · 2019-06-27T18:50:13Z

@izdeby Yes

aten/src/ATen/native/native_functions.yaml

…CPU)." Add a bitwise NOT operator for integer and Boolean types (CPU). Related to #20024, #22246, #22262 gh-metadata: pytorch pytorch 22283 gh/xuhdev/6/head

colesbury

lgtm too

…CPU)." Add a bitwise NOT operator for integer and Boolean types (CPU). Related to #20024, #22246, #22262 gh-metadata: pytorch pytorch 22283 gh/xuhdev/6/head

test/test_torch.py

…CPU)." Add a bitwise NOT operator for integer and Boolean types (CPU). Related to #20024, #22246, #22262 gh-metadata: pytorch pytorch 22283 gh/xuhdev/6/head

xuhdev · 2019-06-30T21:57:33Z

@pytorchbot retest this please

xuhdev · 2019-07-01T04:03:40Z

@pytorchbot retest this please

…CPU)." Add a bitwise NOT operator for integer and Boolean types (CPU). Related to #20024, #22246, #22262 gh-metadata: pytorch pytorch 22283 gh/xuhdev/6/head

xuhdev · 2019-07-01T22:24:32Z

@colesbury @izdeby I changed the code to avoid the template bitwise_not function (and thus the code becomes simpler)

…CPU)." Add a bitwise NOT operator for integer and Boolean types (CPU). Related to #20024, #22246, #22262 gh-metadata: pytorch pytorch 22283 gh/xuhdev/6/head

stale

zou3519 · 2019-07-08T18:21:14Z

@izdeby @colesbury could you take another look at this please?

test/test_torch.py

…CPU)." Add a bitwise NOT operator for integer and Boolean types (CPU). Related to #20024, #22246, #22262 gh-metadata: pytorch pytorch 22283 gh/xuhdev/6/head

Summary: Pull Request resolved: pytorch/pytorch#22283 Test Plan: Imported from OSS Differential Revision: D16183576 Pulled By: colesbury fbshipit-source-id: 2e539fab8ff885dddb9bff334d1d784b28d65b8f

facebook-github-bot · 2019-07-10T22:04:21Z

@colesbury merged this pull request in e2dc1fc.

Add a bitwise NOT operator for integer and Boolean types (CPU).

3589d05

Related to #20024, #22246, #22262

pytorchbot added module: cpu CPU specific problem (e.g., perf, algorithm) module: docs Related to our documentation, both in docs/ and docblocks module: internals Related to internal abstractions in c10 and ATen module: operators labels Jun 26, 2019

Update on "Add a bitwise NOT operator for integer and Boolean types (…

4fc2b22

…CPU)." Add a bitwise NOT operator for integer and Boolean types (CPU). Related to #20024, #22246, #22262 gh-metadata: pytorch pytorch 22283 gh/xuhdev/6/head

ezyang added the open source label Jun 26, 2019

xuhdev added 2 commits June 26, 2019 16:36

Update on "Add a bitwise NOT operator for integer and Boolean types (…

259ee68

…CPU)." Add a bitwise NOT operator for integer and Boolean types (CPU). Related to #20024, #22246, #22262 gh-metadata: pytorch pytorch 22283 gh/xuhdev/6/head

Update on "Add a bitwise NOT operator for integer and Boolean types (…

c0d693d

…CPU)." Add a bitwise NOT operator for integer and Boolean types (CPU). Related to #20024, #22246, #22262 gh-metadata: pytorch pytorch 22283 gh/xuhdev/6/head

Update on "Add a bitwise NOT operator for integer and Boolean types (…

f95d617

…CPU)." Add a bitwise NOT operator for integer and Boolean types (CPU). Related to #20024, #22246, #22262 gh-metadata: pytorch pytorch 22283 gh/xuhdev/6/head

xuhdev requested a review from colesbury June 27, 2019 01:04

Update on "Add a bitwise NOT operator for integer and Boolean types (…

89b293a

…CPU)." Add a bitwise NOT operator for integer and Boolean types (CPU). Related to #20024, #22246, #22262 gh-metadata: pytorch pytorch 22283 gh/xuhdev/6/head

ailzhang requested a review from izdeby June 27, 2019 04:07

ailzhang added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jun 27, 2019

Update on "Add a bitwise NOT operator for integer and Boolean types (…

197a22f

…CPU)." Add a bitwise NOT operator for integer and Boolean types (CPU). Related to #20024, #22246, #22262 gh-metadata: pytorch pytorch 22283 gh/xuhdev/6/head

izdeby suggested changes Jun 27, 2019

View reviewed changes

aten/src/ATen/native/cpu/UnaryOpsKernel.cpp Outdated Show resolved Hide resolved

test/test_torch.py Outdated Show resolved Hide resolved

test/test_torch.py Outdated Show resolved Hide resolved

torch/_torch_docs.py Show resolved Hide resolved

Update on "Add a bitwise NOT operator for integer and Boolean types (…

af834bd

…CPU)." Add a bitwise NOT operator for integer and Boolean types (CPU). Related to #20024, #22246, #22262 gh-metadata: pytorch pytorch 22283 gh/xuhdev/6/head

xuhdev requested a review from izdeby June 27, 2019 16:46

izdeby previously approved these changes Jun 27, 2019

View reviewed changes

colesbury reviewed Jun 27, 2019

View reviewed changes

aten/src/ATen/native/native_functions.yaml Outdated Show resolved Hide resolved

Update on "Add a bitwise NOT operator for integer and Boolean types (…

97b13f1

…CPU)." Add a bitwise NOT operator for integer and Boolean types (CPU). Related to #20024, #22246, #22262 gh-metadata: pytorch pytorch 22283 gh/xuhdev/6/head

colesbury previously approved these changes Jun 27, 2019

View reviewed changes

xuhdev mentioned this pull request Jun 27, 2019

Add a bitwise NOT operator for integer and Boolean types (CUDA). #22320

Closed

xuhdev added 2 commits June 27, 2019 15:33

Update on "Add a bitwise NOT operator for integer and Boolean types (…

fe77182

…CPU)." Add a bitwise NOT operator for integer and Boolean types (CPU). Related to #20024, #22246, #22262 gh-metadata: pytorch pytorch 22283 gh/xuhdev/6/head

Update on "Add a bitwise NOT operator for integer and Boolean types (…

a2437e8

…CPU)." Add a bitwise NOT operator for integer and Boolean types (CPU). Related to #20024, #22246, #22262 gh-metadata: pytorch pytorch 22283 gh/xuhdev/6/head

xuhdev commented Jun 27, 2019

View reviewed changes

test/test_torch.py Show resolved Hide resolved

xuhdev mentioned this pull request Jun 28, 2019

Delegate Python ~ (invert operator) to Tensor.bitwise_not(). #22326

Closed

xuhdev added 2 commits June 30, 2019 09:23

Update on "Add a bitwise NOT operator for integer and Boolean types (…

32bd027

…CPU)." Add a bitwise NOT operator for integer and Boolean types (CPU). Related to #20024, #22246, #22262 gh-metadata: pytorch pytorch 22283 gh/xuhdev/6/head

Update on "Add a bitwise NOT operator for integer and Boolean types (…

6a6e813

…CPU)." Add a bitwise NOT operator for integer and Boolean types (CPU). Related to #20024, #22246, #22262 gh-metadata: pytorch pytorch 22283 gh/xuhdev/6/head

xuhdev added 2 commits July 1, 2019 13:04

Update on "Add a bitwise NOT operator for integer and Boolean types (…

b2d251d

…CPU)." Add a bitwise NOT operator for integer and Boolean types (CPU). Related to #20024, #22246, #22262 gh-metadata: pytorch pytorch 22283 gh/xuhdev/6/head

Update on "Add a bitwise NOT operator for integer and Boolean types (…

3cbe145

…CPU)." Add a bitwise NOT operator for integer and Boolean types (CPU). Related to #20024, #22246, #22262 gh-metadata: pytorch pytorch 22283 gh/xuhdev/6/head

xuhdev requested review from colesbury and izdeby July 1, 2019 22:23

xuhdev added 6 commits July 1, 2019 15:27

Update on "Add a bitwise NOT operator for integer and Boolean types (…

930f762

…CPU)." Add a bitwise NOT operator for integer and Boolean types (CPU). Related to #20024, #22246, #22262 gh-metadata: pytorch pytorch 22283 gh/xuhdev/6/head

Update on "Add a bitwise NOT operator for integer and Boolean types (…

4fbc269

…CPU)." Add a bitwise NOT operator for integer and Boolean types (CPU). Related to #20024, #22246, #22262 gh-metadata: pytorch pytorch 22283 gh/xuhdev/6/head

Update on "Add a bitwise NOT operator for integer and Boolean types (…

5a5c64d

…CPU)." Add a bitwise NOT operator for integer and Boolean types (CPU). Related to #20024, #22246, #22262 gh-metadata: pytorch pytorch 22283 gh/xuhdev/6/head

Update on "Add a bitwise NOT operator for integer and Boolean types (…

62e8fa4

…CPU)." Add a bitwise NOT operator for integer and Boolean types (CPU). Related to #20024, #22246, #22262 gh-metadata: pytorch pytorch 22283 gh/xuhdev/6/head

Update on "Add a bitwise NOT operator for integer and Boolean types (…

b144e5a

…CPU)." Add a bitwise NOT operator for integer and Boolean types (CPU). Related to #20024, #22246, #22262 gh-metadata: pytorch pytorch 22283 gh/xuhdev/6/head

Update on "Add a bitwise NOT operator for integer and Boolean types (…

13199c6

…CPU)." Add a bitwise NOT operator for integer and Boolean types (CPU). Related to #20024, #22246, #22262 gh-metadata: pytorch pytorch 22283 gh/xuhdev/6/head

izdeby reviewed Jul 8, 2019

View reviewed changes

test/test_torch.py Show resolved Hide resolved

izdeby approved these changes Jul 8, 2019

View reviewed changes

Update on "Add a bitwise NOT operator for integer and Boolean types (…

a1491db

…CPU)." Add a bitwise NOT operator for integer and Boolean types (CPU). Related to #20024, #22246, #22262 gh-metadata: pytorch pytorch 22283 gh/xuhdev/6/head

facebook-github-bot closed this in e2dc1fc Jul 10, 2019

zou3519 deleted the gh/xuhdev/6/head branch July 10, 2019 19:20

facebook-github-bot added the merged label Jul 10, 2019

mruberry added the Merged label Oct 28, 2020

Add a bitwise NOT operator for integer and Boolean types (CPU). #22283

Add a bitwise NOT operator for integer and Boolean types (CPU). #22283

Uh oh!

Conversation

xuhdev commented Jun 26, 2019 • edited by colesbury Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xuhdev commented Jun 27, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

izdeby commented Jun 27, 2019

Uh oh!

xuhdev commented Jun 27, 2019

Uh oh!

Uh oh!

colesbury left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

xuhdev commented Jun 30, 2019

Uh oh!

xuhdev commented Jul 1, 2019

Uh oh!

xuhdev commented Jul 1, 2019

Uh oh!

zou3519 commented Jul 8, 2019

Uh oh!

Uh oh!

facebook-github-bot commented Jul 10, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

xuhdev commented Jun 26, 2019 •

edited by colesbury

Loading