Updated docs and added deprecation warnings to acknowledge a bool tensor #22261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytorchbot
added
module: cuda
izdeby
changed the title
izdeby
requested review from
VitalyFedyunin,
ezyang,
gchanan,
li-roy and
ssnl
and removed request for
gchanan and
ssnl
… a bool tensor" Updated docs to acknowledge a bool tensor gh-metadata: pytorch pytorch 22261 gh/izdeby/11/head
ezyang
approved these changes
Jun 26, 2019
li-roy
approved these changes
Jun 26, 2019
gchanan
reviewed
Jul 1, 2019
gchanan
approved these changes
Jul 1, 2019
Contributor
gchanan
left a comment
gchanan
left a comment
There was a problem hiding this comment.
looks good if you change the examples.
… a bool tensor" Updated docs to acknowledge a bool tensor gh-metadata: pytorch pytorch 22261 gh/izdeby/11/head
… a bool tensor" Updated docs to acknowledge a bool tensor gh-metadata: pytorch pytorch 22261 gh/izdeby/11/head
… a bool tensor" Updated docs to acknowledge a bool tensor gh-metadata: pytorch pytorch 22261 gh/izdeby/11/head
… a bool tensor" Updated docs to acknowledge a bool tensor gh-metadata: pytorch pytorch 22261 gh/izdeby/11/head
… a bool tensor" Updated docs to acknowledge a bool tensor gh-metadata: pytorch pytorch 22261 gh/izdeby/11/head
… a bool tensor" Updated docs to acknowledge a bool tensor gh-metadata: pytorch pytorch 22261 gh/izdeby/11/head
… a bool tensor" Stack from [ghstack](https://github.com/ezyang/ghstack): * **#22261 Updated docs to acknowledge a bool tensor** * #21113 [BC-BREAKING] [WIP] Changed tensor comparison return type from uint8 to bool ------------- Change: - Updated docs to mention bool tensor functionality. - Added deprecation warnings to masked methods. Differential Revision: [D16005990](https://our.internmc.facebook.com/intern/diff/D16005990)
… a bool tensor" Stack from [ghstack](https://github.com/ezyang/ghstack): * **#22261 Updated docs to acknowledge a bool tensor** * #21113 [BC-BREAKING] [WIP] Changed tensor comparison return type from uint8 to bool ------------- Change: - Updated docs to mention bool tensor functionality. - Added deprecation warnings to masked methods. Differential Revision: [D16005990](https://our.internmc.facebook.com/intern/diff/D16005990)
… a bool tensor" Stack from [ghstack](https://github.com/ezyang/ghstack): * **#22261 Updated docs to acknowledge a bool tensor** * #21113 [BC-BREAKING] [WIP] Changed tensor comparison return type from uint8 to bool ------------- Change: - Updated docs to mention bool tensor functionality. - Added deprecation warnings to masked methods. Differential Revision: [D16005990](https://our.internmc.facebook.com/intern/diff/D16005990)
… a bool tensor" Stack from [ghstack](https://github.com/ezyang/ghstack): * **#22261 Updated docs to acknowledge a bool tensor** * #21113 [BC-BREAKING] [WIP] Changed tensor comparison return type from uint8 to bool ------------- Change: - Updated docs to mention bool tensor functionality. - Added deprecation warnings to masked methods. Differential Revision: [D16005990](https://our.internmc.facebook.com/intern/diff/D16005990)
… a bool tensor" Stack from [ghstack](https://github.com/ezyang/ghstack): * **#22261 Updated docs to acknowledge a bool tensor** * #21113 [BC-BREAKING] [WIP] Changed tensor comparison return type from uint8 to bool ------------- Change: - Updated docs to mention bool tensor functionality. - Added deprecation warnings to masked methods. Differential Revision: [D16005990](https://our.internmc.facebook.com/intern/diff/D16005990)
… a bool tensor" ------------- Change: - Updated docs to mention bool tensor functionality. - Added deprecation warnings to masked methods. Differential Revision: [D16005990](https://our.internmc.facebook.com/intern/diff/D16005990)
… a bool tensor" ------------- Change: - Updated docs to mention bool tensor functionality. - Added deprecation warnings to masked methods. Differential Revision: [D16005990](https://our.internmc.facebook.com/intern/diff/D16005990)
… a bool tensor" ------------- Change: - Updated docs to mention bool tensor functionality. - Added deprecation warnings to masked methods. Differential Revision: [D16005990](https://our.internmc.facebook.com/intern/diff/D16005990)
pytorchbot
added
the
module: internals
… a bool tensor" ------------- Change: - Updated docs to mention bool tensor functionality. - Added deprecation warnings to masked methods. Differential Revision: [D16005990](https://our.internmc.facebook.com/intern/diff/D16005990)
… a bool tensor" ------------- Change: - Updated docs to mention bool tensor functionality. - Added deprecation warnings to masked methods. Differential Revision: [D16005990](https://our.internmc.facebook.com/intern/diff/D16005990)
… a bool tensor" ------------- Change: - Updated docs to mention bool tensor functionality. - Added deprecation warnings to masked methods. Differential Revision: [D16005990](https://our.internmc.facebook.com/intern/diff/D16005990)
Contributor
Author
… a bool tensor" ------------- Change: - Updated docs to mention bool tensor functionality. - Added deprecation warnings to masked methods. Differential Revision: [D16005990](https://our.internmc.facebook.com/intern/diff/D16005990)
Contributor
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Aug 5, 2019
…sor (#22261) Summary: Pull Request resolved: pytorch/pytorch#22261 ghimport-source-id: 1611d62d056a04c0ad15ef662e594a3d206a78e2 Test Plan: Imported from OSS Differential Revision: D16005990 Pulled By: izdeby fbshipit-source-id: 2413824aa75a0755719e4df11acd21e6607e5a85
pytorchmergebot
pushed a commit
that referenced
this pull request
Mar 7, 2023
`byte` support was marked as deprecated in 1.8, so it's fine to remove this in 2.1 (or even 2.0) Deprecation warning was added by #22261 Also, fix bunch of syntactic errors in comments Pull Request resolved: #96112 Approved by: https://github.com/ezyang
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 12, 2023
`byte` support was marked as deprecated in 1.8, so it's fine to remove this in 2.1 (or even 2.0) Deprecation warning was added by pytorch/pytorch#22261 Also, fix bunch of syntactic errors in comments Pull Request resolved: pytorch/pytorch#96112 Approved by: https://github.com/ezyang
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 12, 2023
`byte` support was marked as deprecated in 1.8, so it's fine to remove this in 2.1 (or even 2.0) Deprecation warning was added by pytorch/pytorch#22261 Also, fix bunch of syntactic errors in comments Pull Request resolved: pytorch/pytorch#96112 Approved by: https://github.com/ezyang
pytorchmergebot
pushed a commit
that referenced
this pull request
Mar 13, 2023
__What?__ Per discussion at #94634, deprecate `masked_fill` with non-bool masks. Deprecation warnings were previously added by #22261, but not for Apple MPS. I can revert the MPS changes if deprecation warnings are wanted first tho. See also #96112. Fixes #85063 and #89320. __Further Development?__ - Fixed the mask dtype checking for the cuda dispatch for `masked_fill` in `aten/src/ATen/native/cuda/Indexing.cu` Pull Request resolved: #96594 Approved by: https://github.com/malfet, https://github.com/ngimel
ydwu4
added a commit
to ydwu4/pytorch
that referenced
this pull request
Mar 13, 2023
) `byte` support was marked as deprecated in 1.8, so it's fine to remove this in 2.1 (or even 2.0) Deprecation warning was added by pytorch#22261 Also, fix bunch of syntactic errors in comments Pull Request resolved: pytorch#96112 Approved by: https://github.com/ezyang
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Change:
Differential Revision: D16005990