Open up AliasAnalysisKind for any ops #22239
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D15996322 Differential Version: 85587929
pytorchbot
added
oncall: jit
Differential Revision: D15996322 Differential Version: 85589060
Differential Revision: D15996322 Differential Version: 85592596
zdevito
approved these changes
Jun 26, 2019
Differential Revision: D15996322 Differential Version: 85652119
Differential Revision: D15996322 Differential Version: 85667386
Differential Revision: D15996322 Differential Version: 85987708
This was referenced Jul 2, 2019
Differential Revision: D15996322 Differential Version: 85991734
Differential Revision: D15996322 Differential Version: 86024668
Closed
Differential Revision: D15996322 Differential Version: 86025316
Differential Revision: D15996322 Differential Version: 8603634
Differential Revision: D15996322 Differential Version: 86040279
Differential Revision: D15996322 Differential Version: 86816470
Differential Revision: D15996322 Differential Version: 86816522
Differential Revision: D15996322 Differential Version: 86816601
Differential Revision: D15996322 Differential Version: 86928350
Differential Revision: D15996322 Differential Version: 86934101
Differential Revision: D15996322 Differential Version: 86939646
Differential Revision: D15996322 Differential Version: 86945800
Differential Revision: D16424851 Differential Version: 86948216
Differential Revision: D15996322 Differential Version: 86948377
Differential Revision: D15996322 Differential Version: 86959708
This was referenced Jul 22, 2019
Closed
Differential Revision: D15996322 Differential Version: 87041763
Differential Revision: D15996322 Differential Version: 87174991
This was referenced Aug 5, 2019
smessmer
added a commit
that referenced
this pull request
Aug 8, 2019
Re-expot of reverted PR #22239 (or actually #23810) with the bug fixed A previous diff removed the special casing for aten:: and prim:: ops in alias analysis and implements alias analysis purely based on the AliasAnalysisKind. To be sure it doesn't break our existing code base, it added asserts that make sure that our existing aten:: and prim:: ops set the correct AliasAnalysisKind. However, we don't need that restriction for future ops. Since we are now certain all existing cases are set up correctly, we can remove these assertions. Differential Revision: [D16657239](https://our.internmc.facebook.com/intern/diff/D16657239/)
smessmer
added a commit
that referenced
this pull request
Aug 9, 2019
Re-expot of reverted PR #22239 (or actually #23810) with the bug fixed A previous diff removed the special casing for aten:: and prim:: ops in alias analysis and implements alias analysis purely based on the AliasAnalysisKind. To be sure it doesn't break our existing code base, it added asserts that make sure that our existing aten:: and prim:: ops set the correct AliasAnalysisKind. However, we don't need that restriction for future ops. Since we are now certain all existing cases are set up correctly, we can remove these assertions. Differential Revision: [D16657239](https://our.internmc.facebook.com/intern/diff/D16657239/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
:black_circle: #22239 Open up AliasAnalysisKind for any ops 💛
:white_circle: #22175 AliasAnalysisKind::CONSERVATIVE/FROM_SCHEMA 💛
A previous diff removed the special casing for aten:: and prim:: ops in alias analysis and implements alias analysis purely
based on the AliasAnalysisKind. To be sure it doesn't break our existing code base, it added asserts that make sure that
our existing aten:: and prim:: ops set the correct AliasAnalysisKind.
However, we don't need that restriction for future ops. Since we are now certain all existing cases are set up correctly,
we can remove these assertions.
Differential Revision: D15996322