[jit] Remove weak script #22212
[jit] Remove weak script #22212
Conversation
pytorchbot
added
oncall: jit
zdevito
left a comment
zdevito
left a comment
There was a problem hiding this comment.
This looks great! Thanks for the progress on cleaning up WeakScriptModule.
Not for this PR but for follow up: we have a lot of free functions in init.py that really should be private methods of the new ScriptModule (e.g. _make_strong_submodule). Also audit init.py for dead code once the WeakScriptModule class itself is removed.
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@driazati has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@driazati has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@driazati has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Thanks for working on this issue. Once landed, I will revise our code according and test the jit mode. |
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@driazati has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@driazati has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@driazati has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@driazati has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: * Deletes all weak script decorators / associated data structures / methods * In order to keep supporting the standard library in script, this enables recursive script on any function defined in `torch.nn` * Most changes in `torch/nn` are the result of `ag -Q "weak" torch/nn/ -l | xargs sed -i '/weak/d'`, only `rnn.py` needed manual editing to use the `ignore` and `export` to continue supporting the overloaded `forward` methods * `Sequential`/`ModuleList` no longer need to be added to constants since they are compiled on demand This should also fix pytorch#22212 Pull Request resolved: pytorch#22212 Differential Revision: D15988346 Pulled By: driazati fbshipit-source-id: af223e3ad0580be895377312949997a70e988e4f
torch.nntorch/nnare the result ofag -Q "weak" torch/nn/ -l | xargs sed -i '/weak/d', onlyrnn.pyneeded manual editing to use the@ignoreand@exportto continue supporting the overloadedforwardmethodsSequential/ModuleListno longer need to be added to constants since they are compiled on demandThis should also fix #22212
Differential Revision: D15988346