[jit] refactor self to be a class again #22207
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I want to get the `type` of self (now that everything is ultimately a class type).
This was referenced Jun 25, 2019
[jit] refactor self to be a class again I want to get the `type` of self (now that everything is ultimately a class type). gh-metadata: pytorch pytorch 22207 gh/suo/71/head
[jit] refactor self to be a class again I want to get the `type` of self (now that everything is ultimately a class type). gh-metadata: pytorch pytorch 22207 gh/suo/71/head
[jit] refactor self to be a class again I want to get the `type` of self (now that everything is ultimately a class type). gh-metadata: pytorch pytorch 22207 gh/suo/71/head
zdevito
reviewed
Jun 28, 2019
| struct Self { | ||
| virtual ~Self() {} | ||
| virtual std::shared_ptr<SugaredValue> makeSugared(Value* v) const = 0; | ||
| virtual ClassTypePtr getClassType() const = 0; |
Contributor
There was a problem hiding this comment.
This is unused in the PR, which makes it hard for me to evaluate this PR on its own. I don't like having to do this because it re-introduces an annoying complexity for this self argument. I don't understand why we can't extract the type for the value (v->type()) or from the schema.
[jit] refactor self to be a class again I want to get the `type` of self (now that everything is ultimately a class type). gh-metadata: pytorch pytorch 22207 gh/suo/71/head
This was referenced Jul 3, 2019
[jit] refactor self to be a class again I want to get the `type` of self (now that everything is ultimately a class type). gh-metadata: pytorch pytorch 22207 gh/suo/71/head
[jit] refactor self to be a class again I want to get the `type` of self (now that everything is ultimately a class type). gh-metadata: pytorch pytorch 22207 gh/suo/71/head
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 9, 2019
Summary:
The error for `test_error_stack_module`:
```
Traceback (most recent call last):
File "../test.py", line 35, in <module>
scripted = torch.jit.script(M())
File "/home/davidriazati/other/pytorch/torch/jit/__init__.py", line 1119, in script
return _convert_to_script_module(obj)
File "/home/davidriazati/other/pytorch/torch/jit/__init__.py", line 1825, in _convert_to_script_module
raise e
RuntimeError:
d(int x) -> int:
Expected a value of type 'int' for argument 'x' but instead found type 'str'.
:
at ../test.py:11:12
def c(x):
return d("hello") + d(x)
~ <--- HERE
'c' is being compiled since it was called from 'b'
at ../test.py:14:12
def b(x):
return c(x)
~~~ <--- HERE
'b' is being compiled since it was called from 'forward'
at ../test.py:22:16
def forward(self, x):
return b(x)
~~~ <--- HERE
'forward' is being compiled since it was called from 'forward'
at ../test.py:31:20
def forward(self, x):
return x + self.submodule(x)
~~~~~~~~~~~~~~~~ <--- HERE
```
This also unifies our error reporting in the front end with `ErrorReport`
TODO
* Include module names in message, #22207 should make this easy
](https://our.intern.facebook.com/intern/diff/16060781/)
Pull Request resolved: #22280
Pulled By: driazati
Differential Revision: D16060781
fbshipit-source-id: c42968b53aaddb774ac69d5abbf7e60c23df8eed
[jit] refactor self to be a class again I want to get the `type` of self (now that everything is ultimately a class type). gh-metadata: pytorch pytorch 22207 gh/suo/71/head
Member
Author
|
Re-requesting review. I mentioned on the above PR: we need to be able to register the fact that the method exists before compiling it, so that methods can find each other. |
zdevito
approved these changes
Jul 10, 2019
Contributor
zdevito
left a comment
zdevito
left a comment
There was a problem hiding this comment.
I think it would be clearer as a separate method, but my opinion here is not very strong.
[jit] refactor self to be a class again I want to get the `type` of self (now that everything is ultimately a class type). gh-metadata: pytorch pytorch 22207 gh/suo/71/head
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
I want to get the
typeof self (now that everything is ultimately aclass type).
Differential Revision: D15998758