[jit] Give functions qualified names #22206
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it so that all code objects owned by a CompilationUnit will have a qualified name. This also means that Module performs one new duty: it does qualified name resolution by concating the Module qualified name with the method name to find the method in the owning CU.
pytorchbot
added
oncall: jit
This was referenced Jun 25, 2019
[jit] Give functions qualified names This makes it so that all code objects owned by a CompilationUnit will have a qualified name. This also means that Module performs one new duty: it does qualified name resolution by concating the Module qualified name with the method name to find the method in the owning CU. gh-metadata: pytorch pytorch 22206 gh/suo/70/head
[jit] Give functions qualified names This makes it so that all code objects owned by a CompilationUnit will have a qualified name. This also means that Module performs one new duty: it does qualified name resolution by concating the Module qualified name with the method name to find the method in the owning CU. gh-metadata: pytorch pytorch 22206 gh/suo/70/head
[jit] Give functions qualified names This makes it so that all code objects owned by a CompilationUnit will have a qualified name. This also means that Module performs one new duty: it does qualified name resolution by concating the Module qualified name with the method name to find the method in the owning CU. gh-metadata: pytorch pytorch 22206 gh/suo/70/head
zdevito
approved these changes
Jun 28, 2019
Contributor
zdevito
left a comment
zdevito
left a comment
There was a problem hiding this comment.
This looks pretty good. The one thing that really should be changed is that define really should not take two definitions for the name (qualName and name in def), and ignore the one in the def. I think we should just add the prefix as part of the define function.
|
|
||
| std::vector<Function*> ClassType::methods() const { | ||
| return compilation_unit()->get_functions(); | ||
| // TODO: this needs to be made more efficient! |
Contributor
There was a problem hiding this comment.
Why can't ClassType hold a list of Function* ?
Member
Author
There was a problem hiding this comment.
I will move that stuff from the other PR to this one.
| // same as above but parse the definitions from source | ||
| void define( | ||
| // prefix namespace to put all the defined functions into | ||
| // If null, |
|
|
||
| Function* ClassType::getMethod(const std::string& name) const { | ||
| return compilation_unit_->find_function(name); | ||
| const auto qualname = QualifiedName(*qualified_name_obj(), name); |
Contributor
There was a problem hiding this comment.
qualified_name_obj is really confusing. If you look at the methods in NamedType they are pretty redundant. We really should have NamedType just return the qualified name and rename qualified_name_obj to just qualifiedName.
|
|
||
| private: | ||
| std::unique_ptr<Function> define( | ||
| const c10::QualifiedName& name, |
Contributor
There was a problem hiding this comment.
I think this should be prefix, otherwise it is denormalized with Def
| } | ||
| c10::optional<Method> find_method(const std::string& name) const { | ||
| if (const auto fn = class_compilation_unit()->find_function(name)) { | ||
| c10::optional<Method> find_method(const std::string& basename) const { |
Contributor
There was a problem hiding this comment.
This runs in the user's eval loop, so I am not really happy about having to allocate a new string in order to look up the function. I feel like the ClassType should just be holding onto this mapping directly.
[jit] Give functions qualified names This makes it so that all code objects owned by a CompilationUnit will have a qualified name. This also means that Module performs one new duty: it does qualified name resolution by concating the Module qualified name with the method name to find the method in the owning CU. gh-metadata: pytorch pytorch 22206 gh/suo/70/head
This was referenced Jul 3, 2019
[jit] Give functions qualified names This makes it so that all code objects owned by a CompilationUnit will have a qualified name. This also means that Module performs one new duty: it does qualified name resolution by concating the Module qualified name with the method name to find the method in the owning CU. gh-metadata: pytorch pytorch 22206 gh/suo/70/head
[jit] Give functions qualified names This makes it so that all code objects owned by a CompilationUnit will have a qualified name. This also means that Module performs one new duty: it does qualified name resolution by concating the Module qualified name with the method name to find the method in the owning CU. gh-metadata: pytorch pytorch 22206 gh/suo/70/head
[jit] Give functions qualified names This makes it so that all code objects owned by a CompilationUnit will have a qualified name. This also means that Module performs one new duty: it does qualified name resolution by concating the Module qualified name with the method name to find the method in the owning CU. gh-metadata: pytorch pytorch 22206 gh/suo/70/head
[jit] Give functions qualified names This makes it so that all code objects owned by a CompilationUnit will have a qualified name. This also means that Module performs one new duty: it does qualified name resolution by concating the Module qualified name with the method name to find the method in the owning CU. gh-metadata: pytorch pytorch 22206 gh/suo/70/head
[jit] Give functions qualified names This makes it so that all code objects owned by a CompilationUnit will have a qualified name. This also means that Module performs one new duty: it does qualified name resolution by concating the Module qualified name with the method name to find the method in the owning CU. gh-metadata: pytorch pytorch 22206 gh/suo/70/head
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This makes it so that all code objects owned by a CompilationUnit will
have a qualified name.
This also means that Module performs one new duty: it does
qualified name resolution by concating the Module qualified name with
the method name to find the method in the owning CU.
Differential Revision: D15998762