Skip to content

Conversation

@XiaobingSuper
Copy link
Collaborator

This PR is to make mkldnn reshape and transpose not exposes as Tensor API, please see the comments in #21943.

@XiaobingSuper
Copy link
Collaborator Author

@bddppq, @soumith, @apaszke, please help review it, thanks!

@XiaobingSuper
Copy link
Collaborator Author

Copy link
Contributor

@bddppq bddppq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to change the function name in aten/src/ATen/native/mkldnn/TensorShape.cpp as well

Copy link
Contributor

@bddppq bddppq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@bddppq bddppq added the module: mkldnn Related to Intel IDEEP or oneDNN (a.k.a. mkldnn) integration label Jun 25, 2019
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bddppq has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

zdevito pushed a commit to zdevito/ATen that referenced this pull request Jun 25, 2019
Summary:
This PR is to make mkldnn reshape and transpose not exposes as Tensor API, please see the comments in pytorch/pytorch#21943.
Pull Request resolved: pytorch/pytorch#22193

Differential Revision: D15983434

Pulled By: bddppq

fbshipit-source-id: ad3514dfd8a3b0d89442eef752864e5d3f3d04f0
@facebook-github-bot
Copy link
Contributor

@bddppq merged this pull request in 9af8ea1.

@XiaobingSuper XiaobingSuper deleted the dissemble-operation branch June 26, 2019 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merged module: mkldnn Related to Intel IDEEP or oneDNN (a.k.a. mkldnn) integration open source

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants