[jit] fix optional type subtype relation #22186
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytorchbot
added
the
module: internals
[jit] fix optional type subtype relation gh-metadata: pytorch pytorch 22186 gh/wanchaol/26/head
nairbv
reviewed
Jun 25, 2019
aten/src/ATen/core/jit_type.h
Outdated
| bool operator==(const Type& rhs) const override { | ||
| if (auto opt_rhs = rhs.cast<OptionalType>()) { | ||
| return getElementType()->isSubtypeOf(opt_rhs->getElementType()); | ||
| return getElementType() == opt_rhs->getElementType(); |
Collaborator
There was a problem hiding this comment.
ah I was looking at this and thinking the operator looked wrong. I tried changing it to this locally but it didn't fix my issue -- didn't realize we'd need the new isSubtypeOf as well to get it to work.
Collaborator
Author
There was a problem hiding this comment.
Yup I think the isSubtypeOf will fix your problem
[jit] fix optional type subtype relation gh-metadata: pytorch pytorch 22186 gh/wanchaol/26/head
…x optional type subtype relation" [jit] fix optional type subtype relation gh-metadata: pytorch pytorch 22186 gh/wanchaol/26/head
ailzhang
approved these changes
Jun 25, 2019
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jun 26, 2019
Summary: Pull Request resolved: pytorch/pytorch#22186 ghimport-source-id: 05ef8c3a176fe2a67d4835888e6db52b57a6d199 Test Plan: Imported from OSS Differential Revision: D15994644 Pulled By: wanchaol fbshipit-source-id: 7c5c4eebd421f6c9470661c2c2eb38bafdff8bbd
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D15994644