[JIT] Write out SourceRanges on save() #22179
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add token stack wire up stack i fucked up something salvageable [JIT] with debug prints no more debug prints pickle stuff
pytorchbot
added
caffe2
oncall: jit
This was referenced Jun 25, 2019
[JIT] Preserve SourceRanges across serialization Add token stack wire up stack i fucked up something salvageable [JIT] with debug prints no more debug prints pickle stuff gh-metadata: pytorch pytorch 22179 gh/jamesr66a/8/head
added 3 commits
June 24, 2019 19:03
[JIT] Preserve SourceRanges across serialization Add token stack wire up stack i fucked up something salvageable [JIT] with debug prints no more debug prints pickle stuff gh-metadata: pytorch pytorch 22179 gh/jamesr66a/8/head
[JIT] Preserve SourceRanges across serialization Add token stack wire up stack i fucked up something salvageable [JIT] with debug prints no more debug prints pickle stuff gh-metadata: pytorch pytorch 22179 gh/jamesr66a/8/head
[JIT] Preserve SourceRanges across serialization Add token stack wire up stack i fucked up something salvageable [JIT] with debug prints no more debug prints pickle stuff gh-metadata: pytorch pytorch 22179 gh/jamesr66a/8/head
jamesr66a
changed the title
zdevito
reviewed
Jun 25, 2019
Contributor
zdevito
left a comment
zdevito
left a comment
There was a problem hiding this comment.
This looks pretty good. I have a couple comments about encapsulating the tagged streams, and making sure we do not create tons of small strings that should be addressed.
[JIT] Preserve SourceRanges across serialization gh-metadata: pytorch pytorch 22179 gh/jamesr66a/8/head
zdevito
reviewed
Jun 27, 2019
Contributor
zdevito
left a comment
zdevito
left a comment
There was a problem hiding this comment.
This is getting close -- I think there are still some bugs distinguishing places where variables are used and where they are defined. We should not be switching the source range when a variable is used. I also have some concerns about how big the debug information is because the source ranges are not being de-duplicated. There are a lot of really small strings " = " That are 3 bytes but will turn into >32 bytes of serialized data in the current format.
added 3 commits
June 27, 2019 21:27
[JIT] Preserve SourceRanges across serialization gh-metadata: pytorch pytorch 22179 gh/jamesr66a/8/head
[JIT] Preserve SourceRanges across serialization gh-metadata: pytorch pytorch 22179 gh/jamesr66a/8/head
[JIT] Preserve SourceRanges across serialization gh-metadata: pytorch pytorch 22179 gh/jamesr66a/8/head
[JIT] Preserve SourceRanges across serialization gh-metadata: pytorch pytorch 22179 gh/jamesr66a/8/head
Contributor
|
@jamesr66a merged this pull request in 2c2a913. |
xzhu1900
pushed a commit
to xzhu1900/pytorch
that referenced
this pull request
Jul 5, 2019
Summary: Pull Request resolved: pytorch#22179 ghimport-source-id: 9879551 Test Plan: Imported from OSS Differential Revision: D15981423 Pulled By: jamesr66a fbshipit-source-id: a2506f5a2f05916b6e8226841b0229110e758671
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D15981423