[JIT] Serialization methods for SourceRange and Source #22178
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 25, 2019
added 2 commits
June 24, 2019 19:03
[JIT] Serialization methods for SourceRange and Source gh-metadata: pytorch pytorch 22178 gh/jamesr66a/7/head
[JIT] Serialization methods for SourceRange and Source gh-metadata: pytorch pytorch 22178 gh/jamesr66a/7/head
zdevito
reviewed
Jun 25, 2019
Contributor
zdevito
left a comment
zdevito
left a comment
There was a problem hiding this comment.
The methods need to be put into a separate compilation unit to avoid bloating the dependency tree for source_range objects, which are widely used.
[JIT] Serialization methods for SourceRange and Source gh-metadata: pytorch pytorch 22178 gh/jamesr66a/7/head
zdevito
approved these changes
Jun 27, 2019
| c10::IValue serialize(const SourceRange& sr) { | ||
| std::vector<c10::IValue> elements = { | ||
| serialize_source(sr.source()), (int64_t)sr.start(), (int64_t)sr.end()}; | ||
| return c10::ivalue::Tuple::create(elements); |
| } | ||
| std::vector<c10::IValue> elements{ | ||
| s->text(), s->filename(), (int64_t)s->starting_line_no()}; | ||
| auto serialized = c10::ivalue::Tuple::create(elements); |
added 3 commits
June 27, 2019 21:27
[JIT] Serialization methods for SourceRange and Source gh-metadata: pytorch pytorch 22178 gh/jamesr66a/7/head
[JIT] Serialization methods for SourceRange and Source gh-metadata: pytorch pytorch 22178 gh/jamesr66a/7/head
[JIT] Serialization methods for SourceRange and Source gh-metadata: pytorch pytorch 22178 gh/jamesr66a/7/head
Contributor
|
@jamesr66a merged this pull request in e05942c. |
xzhu1900
pushed a commit
to xzhu1900/pytorch
that referenced
this pull request
Jul 5, 2019
Summary: Pull Request resolved: pytorch#22178 ghimport-source-id: 85ca4d4 Test Plan: Imported from OSS Differential Revision: D15981426 Pulled By: jamesr66a fbshipit-source-id: f81f5ee3b66fc4a0d4a708b8109712b5df9f241a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D15981426