[JIT] Refactor file:line:col to be less ugly #22177
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 25, 2019
added 2 commits
June 24, 2019 19:03
[JIT] Refactor file:line:col to be less ugly gh-metadata: pytorch pytorch 22177 gh/jamesr66a/6/head
[JIT] Refactor file:line:col to be less ugly gh-metadata: pytorch pytorch 22177 gh/jamesr66a/6/head
[JIT] Refactor file:line:col to be less ugly gh-metadata: pytorch pytorch 22177 gh/jamesr66a/6/head
zdevito
approved these changes
Jun 26, 2019
| return ss.str(); | ||
| } | ||
|
|
||
| c10::optional<std::tuple<std::string, size_t, size_t>> file_line_col() const { |
Contributor
There was a problem hiding this comment.
perf: This is creating a copy of the filename string for every line of the output.
added 3 commits
June 27, 2019 21:27
[JIT] Refactor file:line:col to be less ugly gh-metadata: pytorch pytorch 22177 gh/jamesr66a/6/head
[JIT] Refactor file:line:col to be less ugly gh-metadata: pytorch pytorch 22177 gh/jamesr66a/6/head
[JIT] Refactor file:line:col to be less ugly gh-metadata: pytorch pytorch 22177 gh/jamesr66a/6/head
Contributor
|
@jamesr66a merged this pull request in 671782d. |
xzhu1900
pushed a commit
to xzhu1900/pytorch
that referenced
this pull request
Jul 5, 2019
Summary: Pull Request resolved: pytorch#22177 ghimport-source-id: e35f068 Test Plan: Imported from OSS Differential Revision: D15981424 Pulled By: jamesr66a fbshipit-source-id: b7748c5cfd4f8ea594314cb601a2b8045173700a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D15981424