Refactor and improve randperm tests. #22121
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously randperm supports Half type only on CUDA. This commit adds Half support for the CPU version. Precision check for floating point type is also added to ensure that integers can be properly represented.
pytorchbot
added
module: cuda
This was referenced Jun 23, 2019
Refactor and improve randperm tests. gh-metadata: pytorch pytorch 22121 gh/xuhdev/3/head
Refactor and improve randperm tests. gh-metadata: pytorch pytorch 22121 gh/xuhdev/3/head
Refactor and improve randperm tests. gh-metadata: pytorch pytorch 22121 gh/xuhdev/3/head
ssnl
reviewed
Jun 24, 2019
Refactor and improve randperm tests. gh-metadata: pytorch pytorch 22121 gh/xuhdev/3/head
Refactor and improve randperm tests. gh-metadata: pytorch pytorch 22121 gh/xuhdev/3/head
soumith
approved these changes
Jun 25, 2019
soumith
added
the
triaged
yf225
approved these changes
Jun 26, 2019
Contributor
|
I'm not able to import this PR... cc : @yf225 do you know how to fix? |
Collaborator
Author
|
@ailzhang I guess the other two dependency PRs must be imported first? |
Refactor and improve randperm tests. gh-metadata: pytorch pytorch 22121 gh/xuhdev/3/head
Refactor and improve randperm tests. gh-metadata: pytorch pytorch 22121 gh/xuhdev/3/head
Refactor and improve randperm tests. gh-metadata: pytorch pytorch 22121 gh/xuhdev/3/head
Collaborator
Author
|
@pytorchbot retest this please |
1 similar comment
Contributor
|
@pytorchbot retest this please |
Refactor and improve randperm tests. gh-metadata: pytorch pytorch 22121 gh/xuhdev/3/head
Refactor and improve randperm tests. gh-metadata: pytorch pytorch 22121 gh/xuhdev/3/head
Contributor
|
CI failure looks unrelated. |
Refactor and improve randperm tests. gh-metadata: pytorch pytorch 22121 gh/xuhdev/3/head
Refactor and improve randperm tests. gh-metadata: pytorch pytorch 22121 gh/xuhdev/3/head
Refactor and improve randperm tests. gh-metadata: pytorch pytorch 22121 gh/xuhdev/3/head
Refactor and improve randperm tests. gh-metadata: pytorch pytorch 22121 gh/xuhdev/3/head
Collaborator
Author
|
@pytorchbot merge this please |
pytorchbot
added
the
merge-this-please
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D16153794