[JIT] Fix isSubtypeOf implementations #22104
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytorchbot
added
the
module: internals
apaszke
reviewed
Jun 22, 2019
Contributor
|
Also, looks like we also don't fall back on |
[JIT] Fix isSubtypeOf implementations gh-metadata: pytorch pytorch 22104 gh/jamesr66a/11/head
jamesr66a
changed the title
apaszke
approved these changes
Jun 22, 2019
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jun 23, 2019
Summary: Pull Request resolved: pytorch/pytorch#22104 ghimport-source-id: 9db14020f424cf2e021d63e9c0fe4017ac7cd6c8 Test Plan: Imported from OSS Differential Revision: D15956726 Pulled By: jamesr66a fbshipit-source-id: 85448deab70c5e5b7ab1132652836ed575581868
Contributor
|
@jamesr66a merged this pull request in 887ecf7. |
zdevito
reviewed
Jun 24, 2019
| return create(contained_types[0]); | ||
| } | ||
|
|
||
| bool operator==(const Type& rhs) const override { |
Contributor
There was a problem hiding this comment.
Optional[Int] == Option[Number]?
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jun 26, 2019
Summary: This is (mostly) the re-application of: pytorch/pytorch#21088 which was reverted due to an issue conflicting with changes in: pytorch/pytorch#22104 Pull Request resolved: pytorch/pytorch#22237 Differential Revision: D16012838 Pulled By: nairbv fbshipit-source-id: 35f4a73c97ab68b4e2648aca96b2176f07b5a883
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D15956726
Previously the following would fail:
Because
Dict[int, str] issubtypeof Optional[Dict[int,str]]would return false, as we did not fall back toisSubtypeOfdefined in `Type. This fixes that