Support Half type in randperm. #22102
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytorchbot
added
module: cuda
This was referenced Jun 22, 2019
Collaborator
Author
|
@pytorchbot retest this please |
Support Half type in randperm. gh-metadata: pytorch pytorch 22102 gh/xuhdev/1/head
Collaborator
Author
|
@pytorchbot retest this please |
Support Half type in randperm. gh-metadata: pytorch pytorch 22102 gh/xuhdev/1/head
Support Half type in randperm. Previously randperm supports Half type only on CUDA. This commit adds Half support for the CPU version. Precision check for floating point type is also added to ensure that integers can be properly represented. gh-metadata: pytorch pytorch 22102 gh/xuhdev/1/head
Support Half type in randperm. Previously randperm supports Half type only on CUDA. This commit adds Half support for the CPU version. Precision check for floating point type is also added to ensure that integers can be properly represented. gh-metadata: pytorch pytorch 22102 gh/xuhdev/1/head
Support Half type in randperm. Previously randperm supports Half type only on CUDA. This commit adds Half support for the CPU version. Precision check for floating point type is also added to ensure that integers can be properly represented. gh-metadata: pytorch pytorch 22102 gh/xuhdev/1/head
soumith
added
triaged
Support Half type in randperm. Previously randperm supports Half type only on CUDA. This commit adds Half support for the CPU version. Precision check for floating point type is also added to ensure that integers can be properly represented. gh-metadata: pytorch pytorch 22102 gh/xuhdev/1/head
Support Half type in randperm. Previously randperm supports Half type only on CUDA. This commit adds Half support for the CPU version. Precision check for floating point type is also added to ensure that integers can be properly represented. gh-metadata: pytorch pytorch 22102 gh/xuhdev/1/head
Support Half type in randperm. Previously randperm supports Half type only on CUDA. This commit adds Half support for the CPU version. Precision check for floating point type is also added to ensure that integers can be properly represented. gh-metadata: pytorch pytorch 22102 gh/xuhdev/1/head
gchanan
reviewed
Jul 1, 2019
Support Half type in randperm. Previously randperm supports Half type only on CUDA. This commit adds Half support for the CPU version. Precision check for floating point type is also added to ensure that integers can be properly represented. gh-metadata: pytorch pytorch 22102 gh/xuhdev/1/head
Support Half type in randperm. Previously randperm supports Half type only on CUDA. This commit adds Half support for the CPU version. Precision check for floating point type is also added to ensure that integers can be properly represented. gh-metadata: pytorch pytorch 22102 gh/xuhdev/1/head
Contributor
|
CI failures look unrelated. |
gchanan
approved these changes
Jul 2, 2019
Support Half type in randperm. Previously randperm supports Half type only on CUDA. This commit adds Half support for the CPU version. Precision check for floating point type is also added to ensure that integers can be properly represented. gh-metadata: pytorch pytorch 22102 gh/xuhdev/1/head
Support Half type in randperm. Previously randperm supports Half type only on CUDA. This commit adds Half support for the CPU version. Precision check for floating point type is also added to ensure that integers can be properly represented. gh-metadata: pytorch pytorch 22102 gh/xuhdev/1/head
Support Half type in randperm. Previously randperm supports Half type only on CUDA. This commit adds Half support for the CPU version. Precision check for floating point type is also added to ensure that integers can be properly represented. gh-metadata: pytorch pytorch 22102 gh/xuhdev/1/head
Support Half type in randperm. Previously randperm supports Half type only on CUDA. This commit adds Half support for the CPU version. Precision check for floating point type is also added to ensure that integers can be properly represented. gh-metadata: pytorch pytorch 22102 gh/xuhdev/1/head
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jul 10, 2019
Summary: Pull Request resolved: pytorch/pytorch#22102 Test Plan: Imported from OSS Differential Revision: D16153586 Pulled By: li-roy fbshipit-source-id: d58e3dbc5da893005f4eaf521a28b0d752274eff
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Previously randperm supports Half type only on CUDA. This commit adds
Half support for the CPU version. Precision check for floating point
type is also added to ensure that integers can be properly represented.
Differential Revision: D16153586