Fixed list() not making a copy #22093
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driazati
approved these changes
Jun 21, 2019
apaszke
suggested changes
Jun 22, 2019
Chillee
force-pushed
the
fixlistfunction
branch
2 times, most recently
from
7fd91c6 to
dbbdef1
Compare
Collaborator
Author
|
I've responded to all comments, can I get a re-review? |
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@Chillee is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
xzhu1900
pushed a commit
to xzhu1900/pytorch
that referenced
this pull request
Jul 5, 2019
Summary: Fixes pytorch#22087 Pull Request resolved: pytorch#22093 Differential Revision: D16036814 Pulled By: Chillee fbshipit-source-id: 3c7106f907415ed0f600acaf45d2c61e1c60867a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22087