Use at::detail::* instead of detail::* to avoid ambiguity in windows #22029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytorchbot
added
module: cuda
…in windows" Use at::detail::* instead of detail::* to avoid ambiguity in windows gh-metadata: pytorch pytorch 22029 gh/syed-ahmed/15/head
This was referenced Jun 21, 2019
ezyang
approved these changes
Jun 24, 2019
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jun 24, 2019
…(#22029) Summary: Pull Request resolved: pytorch/pytorch#22029 ghimport-source-id: d1a26a07faf101c644775267a141ba56cbd3f1c9 Test Plan: Imported from OSS Differential Revision: D15965039 Pulled By: ezyang fbshipit-source-id: 31baf405da6f7c6d9e31f5954ec827889dadf769
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary
Looks like Windows build fails because I used detail::Array in the at::native namespace, which confuses windows as there is a detail namespace in at::native. I used the full at::detail::Array in this patch, hoping it will resolve the issue: #21555 (comment)
Differential Revision: D15965039