[jit] add for in string support #21990
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 19, 2019
[jit] add for in string support gh-metadata: pytorch pytorch 21990 gh/wanchaol/24/head
This was referenced Jun 20, 2019
[jit] add for in string support gh-metadata: pytorch pytorch 21990 gh/wanchaol/24/head
zdevito
approved these changes
Jun 21, 2019
| Value* cur_elem = nullptr; | ||
| if (val_type->cast<ListType>()) { | ||
| cur_elem = g.insert(aten::select, {val, i}, {}, loc); | ||
| } else if (val_type->cast<StringType>()) { |
Contributor
There was a problem hiding this comment.
It would be nice to standardize a builtin like "getelem" to be used here rather than have a big if branch that emits different code, similar to our other magic methods. Furthermore, we should make serialization emit this as foo[i] so that we do not end up getting committed to preserving these operator names.
Collaborator
Author
There was a problem hiding this comment.
I agree with this, will make a separate PR to define it. We will need to follow up on design the deprecation strategy of those prim operators that should be deleted.
[jit] add for in string support gh-metadata: pytorch pytorch 21990 gh/wanchaol/24/head
[jit] add for in string support gh-metadata: pytorch pytorch 21990 gh/wanchaol/24/head
[jit] add for in string support gh-metadata: pytorch pytorch 21990 gh/wanchaol/24/head
[jit] add for in string support gh-metadata: pytorch pytorch 21990 gh/wanchaol/24/head
[jit] add for in string support gh-metadata: pytorch pytorch 21990 gh/wanchaol/24/head
Contributor
wanchaol
added a commit
that referenced
this pull request
Jun 26, 2019
Summary: Follow up of #21990, I am switching index select operations to a standard __getitem__ builtin, rather than bunch of different builtins according to the type, such as prim::DictIndex, prim::ListIndex, etc. This will also aligned with the some other magic methods that we already use
wanchaol
added a commit
that referenced
this pull request
Jun 26, 2019
Summary: Follow up of #21990, I am switching index select operations to a standard __getitem__ builtin, rather than bunch of different builtins according to the type, such as prim::DictIndex, prim::ListIndex, etc. This will also aligned with the some other magic methods that we already use gh-metadata: pytorch pytorch 22276 gh/wanchaol/28/head
wanchaol
added a commit
that referenced
this pull request
Jun 28, 2019
Summary: Follow up of #21990, I am switching index select operations to a standard __getitem__ builtin, rather than bunch of different builtins according to the type, such as prim::DictIndex, prim::ListIndex, etc. This will also aligned with the some other magic methods that we already use gh-metadata: pytorch pytorch 22276 gh/wanchaol/28/head
wanchaol
added a commit
that referenced
this pull request
Jun 28, 2019
[jit] register __getitem__ builtin Summary: Follow up of #21990, I am switching index select operations to a standard __getitem__ builtin, rather than bunch of different builtins according to the type, such as prim::DictIndex, prim::ListIndex, etc. This will also aligned with the some other magic methods that we already use gh-metadata: pytorch pytorch 22276 gh/wanchaol/28/head
wanchaol
added a commit
that referenced
this pull request
Jul 3, 2019
[jit] register __getitem__ builtin Summary: Follow up of #21990, I am switching index select operations to a standard __getitem__ builtin, rather than bunch of different builtins according to the type, such as prim::DictIndex, prim::ListIndex, etc. This will also aligned with the some other magic methods that we already use gh-metadata: pytorch pytorch 22276 gh/wanchaol/28/head
wanchaol
added a commit
that referenced
this pull request
Jul 3, 2019
[jit] register __getitem__ builtin Summary: Follow up of #21990, I am switching index select operations to a standard __getitem__ builtin, rather than bunch of different builtins according to the type, such as prim::DictIndex, prim::ListIndex, etc. This will also aligned with the some other magic methods that we already use gh-metadata: pytorch pytorch 22276 gh/wanchaol/28/head
wanchaol
added a commit
that referenced
this pull request
Jul 3, 2019
[jit] register __getitem__ builtin Summary: Follow up of #21990, I am switching index select operations to a standard __getitem__ builtin, rather than bunch of different builtins according to the type, such as prim::DictIndex, prim::ListIndex, etc. This will also aligned with the some other magic methods that we already use gh-metadata: pytorch pytorch 22276 gh/wanchaol/28/head
wanchaol
added a commit
that referenced
this pull request
Jul 3, 2019
Summary: Follow up of #21990, I am switching index select operations to a standard __getitem__ builtin, rather than bunch of different builtins according to the type, such as prim::DictIndex, prim::ListIndex, etc. This will also aligned with the some other magic methods that we already use gh-metadata: pytorch pytorch 22276 gh/wanchaol/28/head
wanchaol
added a commit
that referenced
this pull request
Jul 10, 2019
[jit] register __getitem__ builtin Summary: Follow up of #21990, I am switching index select operations to a standard __getitem__ builtin, rather than bunch of different builtins according to the type, such as prim::DictIndex, prim::ListIndex, etc. This will also aligned with the some other magic methods that we already use gh-metadata: pytorch pytorch 22276 gh/wanchaol/28/head
wanchaol
added a commit
that referenced
this pull request
Jul 10, 2019
[jit] register __getitem__ builtin Summary: Follow up of #21990, I am switching index select operations to a standard __getitem__ builtin, rather than bunch of different builtins according to the type, such as prim::DictIndex, prim::ListIndex, etc. This will also aligned with the some other magic methods that we already use gh-metadata: pytorch pytorch 22276 gh/wanchaol/28/head
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D15948547