-
Notifications
You must be signed in to change notification settings - Fork 26.3k
Add torch.where overload with only condition argument
#21986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| add_docstr(torch.where, | ||
| r""" | ||
| where(condition, x, y) -> Tensor | ||
| .. function:: where(condition, x, y) -> Tensor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't this either a different function or the optional x, y need to be explained in some way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whoops, didn't see the line below, my mistake.
|
Wow, NumPy API is so weird. |
|
@pytorchbot retest this please |
facebook-github-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zhangguanheng66 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@umanwizard Could you rebase and resolve the merge conflicts? I tried to land the diff and got merge conflict warnings. Thanks. |
facebook-github-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zhangguanheng66 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: Requested in pytorch/pytorch#21798 Pull Request resolved: pytorch/pytorch#21986 Differential Revision: D16081577 Pulled By: zhangguanheng66 fbshipit-source-id: 658c0f451b833aceb1a41ee424c7990eec00bc02
|
@zhangguanheng66 merged this pull request in e210c65. |
Summary: Requested in pytorch#21798 Pull Request resolved: pytorch#21986 Differential Revision: D16081577 Pulled By: zhangguanheng66 fbshipit-source-id: 658c0f451b833aceb1a41ee424c7990eec00bc02
Requested in #21798