Skip to content

Conversation

@umanwizard
Copy link
Contributor

Requested in #21798

@umanwizard umanwizard requested review from colesbury and fmassa June 19, 2019 20:41
@pytorchbot pytorchbot added module: docs Related to our documentation, both in docs/ and docblocks module: internals Related to internal abstractions in c10 and ATen module: operators labels Jun 19, 2019
@umanwizard umanwizard requested a review from gchanan June 21, 2019 18:33
add_docstr(torch.where,
r"""
where(condition, x, y) -> Tensor
.. function:: where(condition, x, y) -> Tensor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't this either a different function or the optional x, y need to be explained in some way?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops, didn't see the line below, my mistake.

@apaszke
Copy link
Contributor

apaszke commented Jun 22, 2019

Wow, NumPy API is so weird.

@zhangguanheng66
Copy link
Contributor

@pytorchbot retest this please

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhangguanheng66 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@zhangguanheng66
Copy link
Contributor

@umanwizard Could you rebase and resolve the merge conflicts? I tried to land the diff and got merge conflict warnings. Thanks.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhangguanheng66 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

zdevito pushed a commit to zdevito/ATen that referenced this pull request Jul 3, 2019
Summary:
Requested in pytorch/pytorch#21798
Pull Request resolved: pytorch/pytorch#21986

Differential Revision: D16081577

Pulled By: zhangguanheng66

fbshipit-source-id: 658c0f451b833aceb1a41ee424c7990eec00bc02
@facebook-github-bot
Copy link
Contributor

@zhangguanheng66 merged this pull request in e210c65.

xzhu1900 pushed a commit to xzhu1900/pytorch that referenced this pull request Jul 5, 2019
Summary:
Requested in pytorch#21798
Pull Request resolved: pytorch#21986

Differential Revision: D16081577

Pulled By: zhangguanheng66

fbshipit-source-id: 658c0f451b833aceb1a41ee424c7990eec00bc02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merged module: docs Related to our documentation, both in docs/ and docblocks module: internals Related to internal abstractions in c10 and ATen open source

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants