[jit] support iteration tuple unpacking #21985
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 19, 2019
[jit] support iteration tuple unpacking gh-metadata: pytorch pytorch 21985 gh/wanchaol/23/head
This was referenced Jun 20, 2019
[jit] support iteration tuple unpacking gh-metadata: pytorch pytorch 21985 gh/wanchaol/23/head
zdevito
approved these changes
Jun 21, 2019
Contributor
zdevito
left a comment
zdevito
left a comment
There was a problem hiding this comment.
Looks good, one question.
| emitExprsAssign(target_exprs, {sv}, range, n_binders); | ||
| // if target exprs are more than 1, it means iteration unpacking on LHS | ||
| // we create Tuple literal to wrap those target exprs for assignments | ||
| if (target_exprs.size() > 1) { |
Contributor
There was a problem hiding this comment.
Why is it necessary to create a list here vs just passing more than one target_expr to emitExprsAssign?
Collaborator
Author
There was a problem hiding this comment.
Oh it's because sv here is the root IterableTree (which create TupleConstruct in getelem) and need to call emitTupleAssign to unwrap the tuple using asTuple, but the target_exprs here is not a tupleliteral, so emitExprsAssign could not match these two together, and we need to create a TupleLiteral wrap here.
[jit] support iteration tuple unpacking gh-metadata: pytorch pytorch 21985 gh/wanchaol/23/head
[jit] support iteration tuple unpacking gh-metadata: pytorch pytorch 21985 gh/wanchaol/23/head
[jit] support iteration tuple unpacking gh-metadata: pytorch pytorch 21985 gh/wanchaol/23/head
[jit] support iteration tuple unpacking gh-metadata: pytorch pytorch 21985 gh/wanchaol/23/head
[jit] support iteration tuple unpacking gh-metadata: pytorch pytorch 21985 gh/wanchaol/23/head
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Fixes #20239
Differential Revision: D15948549