[jit] Add the rest of the dict API
#21979
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytorchbot
added
module: internals
wanchaol
reviewed
Jun 24, 2019
Collaborator
wanchaol
left a comment
wanchaol
left a comment
There was a problem hiding this comment.
looks good, only have nits. also clang-tidy seems complaining.
assuming CI passes
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jun 26, 2019
Summary: This adds the rest of the `dict.???` methods that were missing Pull Request resolved: pytorch/pytorch#21979 Pulled By: driazati Differential Revision: D15999938 fbshipit-source-id: 7bc2a55e3f791015a0ff2e3731703075cf0770ee
Contributor
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jun 27, 2019
Summary: This adds the rest of the `dict.???` methods that were missing Pull Request resolved: pytorch/pytorch#21979 Pulled By: driazati Differential Revision: D16023573 fbshipit-source-id: 3ea9bd905090e2a176af654a8ca98c7d965ea679
eellison
reviewed
Jul 5, 2019
| case prim::Print: | ||
| case prim::RaiseException: | ||
| case prim::SetAttr: | ||
| case aten::clear: |
Contributor
There was a problem hiding this comment.
You shouldn't have to add either of these to hasSideEffects if the aliasing annotation is correct
xzhu1900
pushed a commit
to xzhu1900/pytorch
that referenced
this pull request
Jul 5, 2019
Summary: This adds the rest of the `dict.???` methods that were missing Pull Request resolved: pytorch#21979 Pulled By: driazati Differential Revision: D16023573 fbshipit-source-id: 3ea9bd905090e2a176af654a8ca98c7d965ea679
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the rest of the
dict.???methods that were missingDifferential Revision: D16023573