[JIT] Fix WeakIValueEq #21891
Closed
[JIT] Fix WeakIValueEq #21891
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytorchbot
added
oncall: jit
zdevito
approved these changes
Jun 18, 2019
Contributor
zdevito
left a comment
zdevito
left a comment
There was a problem hiding this comment.
Tell me how a RMBK WeakIValue table explodes?
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jun 18, 2019
Summary: Pull Request resolved: pytorch/pytorch#21891 ghimport-source-id: a037850c96fe803540412db9a88548fa41f2d4f0 Test Plan: Imported from OSS Differential Revision: D15871588 Pulled By: jamesr66a fbshipit-source-id: ecfdece1285c0737d0b1dc2afe959c43d9413001
Contributor
|
@jamesr66a merged this pull request in 28ecc10. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This was causing nondeterministic failures during tracing
Differential Revision: D15871588