Add slot_list/slot_iterator #21874
Closed
Add slot_list/slot_iterator #21874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: we've change implementation of iterating over parameters/attributes/modules many times, and each time we've had to slightly break backward compatibility. This changes the api to use a class to encapsulate iteration of parameters/attributes/modules. This should allow us to make implementation changes without affecting the user API.
pytorchbot
added
oncall: jit
This was referenced Jun 17, 2019
suo
approved these changes
Jun 17, 2019
| return a.i_ != b.i_; | ||
| } | ||
|
|
||
| struct slot_list { |
Member
There was a problem hiding this comment.
Can you add a comment explaining what this (and slot_iterator) is for/what problem it solves
Contributor
Author
|
I am going to squash this PR into the previous one, because they expose 2 sets of BC breaking changes and I would rather do it in one go. This also allows me to address the comment in the previous PR about not returning std::shared_ptr anymore. |
Contributor
Author
|
merged into another commit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary: we've change implementation of iterating over parameters/attributes/modules
many times, and each time we've had to slightly break backward compatibility.
This changes the api to use a class to encapsulate iteration of parameters/attributes/modules.
This should allow us to make implementation changes without affecting the user API.
Differential Revision: D15864719