Port symeig to ATen and enable batching of inputs #21858
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytorchbot
added
module: cpu
14 tasks
vishwakftw
changed the title
pytorchbot
added
module: docs
Contributor
Author
|
@pytorchbot rebase this please |
Contributor
Author
|
Windows build failures are spurious. |
Contributor
Author
|
@pytorchbot rebase this please |
Contributor
Author
|
@pytorchbot rebase this please |
soumith
approved these changes
Jun 25, 2019
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@soumith is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
Author
|
Thank you for the review. |
Contributor
Author
|
@soumith is there I need to do to help get this landed? |
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jun 25, 2019
Summary: Changelog: - Port `symeig` from TH/THC to ATen - Enable batching of matrix inputs for `symeig` - Modify derivative computation based on batching - Update docs to reflect the change Pull Request resolved: pytorch/pytorch#21858 Test Plan: - Added additional tests in `test_torch.py` (with a port to `test_cuda.py`) and `common_methods_invocations.py` to test if both the port and batching work. Differential Revision: D15981789 Pulled By: soumith fbshipit-source-id: ab9af8361f8608db42318aabc8421bd99a1ca7ae
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog:
symeigfrom TH/THC to ATensymeigTest Plan:
test_torch.py(with a port totest_cuda.py) andcommon_methods_invocations.pyto test if both the port and batching work.