Add interface declarations to JIT #21853
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: this is the first commit in a series to add interfaces to JIT. Interfaces allow the specification through a blank python class of an abstract interface that can be used in type annotations for Script functions. If a TorchScript class implements all the methods in the interface with the appropriate types, then it is implicitly considered to implement that interface. Follows required: * implementation of serialization * implementation in the parser frontend * better error reporting for explaining why a class does not meet an interface specification.
pytorchbot
added
oncall: jit
This was referenced Jun 17, 2019
zdevito
commented
Jun 17, 2019
| return {def.name().name(), "", std::move(arguments), std::move(returns)}; | ||
| } | ||
|
|
||
| std::vector<IValue> evaluateDefaults( |
Contributor
Author
There was a problem hiding this comment.
only change here is a move to ScriptTypeParser
Add interface declarations to JIT Summary: this is the first commit in a series to add interfaces to JIT. Interfaces allow the specification through a blank python class of an abstract interface that can be used in type annotations for Script functions. If a TorchScript class implements all the methods in the interface with the appropriate types, then it is implicitly considered to implement that interface. Follows required: * implementation of serialization * implementation in the parser frontend * better error reporting for explaining why a class does not meet an interface specification. gh-metadata: pytorch pytorch 21853 gh/zdevito/66/head
Add interface declarations to JIT Summary: this is the first commit in a series to add interfaces to JIT. Interfaces allow the specification through a blank python class of an abstract interface that can be used in type annotations for Script functions. If a TorchScript class implements all the methods in the interface with the appropriate types, then it is implicitly considered to implement that interface. Follows required: * implementation of serialization * implementation in the parser frontend * better error reporting for explaining why a class does not meet an interface specification. gh-metadata: pytorch pytorch 21853 gh/zdevito/66/head
Add interface declarations to JIT Summary: this is the first commit in a series to add interfaces to JIT. Interfaces allow the specification through a blank python class of an abstract interface that can be used in type annotations for Script functions. If a TorchScript class implements all the methods in the interface with the appropriate types, then it is implicitly considered to implement that interface. Follows required: * implementation of serialization * implementation in the parser frontend * better error reporting for explaining why a class does not meet an interface specification. gh-metadata: pytorch pytorch 21853 gh/zdevito/66/head
Add interface declarations to JIT Summary: this is the first commit in a series to add interfaces to JIT. Interfaces allow the specification through a blank python class of an abstract interface that can be used in type annotations for Script functions. If a TorchScript class implements all the methods in the interface with the appropriate types, then it is implicitly considered to implement that interface. Follows required: * implementation of serialization * implementation in the parser frontend * better error reporting for explaining why a class does not meet an interface specification. gh-metadata: pytorch pytorch 21853 gh/zdevito/66/head
Add interface declarations to JIT Summary: this is the first commit in a series to add interfaces to JIT. Interfaces allow the specification through a blank python class of an abstract interface that can be used in type annotations for Script functions. If a TorchScript class implements all the methods in the interface with the appropriate types, then it is implicitly considered to implement that interface. Follows required: * implementation of serialization * implementation in the parser frontend * better error reporting for explaining why a class does not meet an interface specification. gh-metadata: pytorch pytorch 21853 gh/zdevito/66/head
Add interface declarations to JIT Summary: this is the first commit in a series to add interfaces to JIT. Interfaces allow the specification through a blank python class of an abstract interface that can be used in type annotations for Script functions. If a TorchScript class implements all the methods in the interface with the appropriate types, then it is implicitly considered to implement that interface. Follows required: * implementation of serialization * implementation in the parser frontend * better error reporting for explaining why a class does not meet an interface specification. gh-metadata: pytorch pytorch 21853 gh/zdevito/66/head
Add interface declarations to JIT Summary: this is the first commit in a series to add interfaces to JIT. Interfaces allow the specification through a blank python class of an abstract interface that can be used in type annotations for Script functions. If a TorchScript class implements all the methods in the interface with the appropriate types, then it is implicitly considered to implement that interface. Follows required: * implementation of serialization * implementation in the parser frontend * better error reporting for explaining why a class does not meet an interface specification. gh-metadata: pytorch pytorch 21853 gh/zdevito/66/head
Add interface declarations to JIT Summary: this is the first commit in a series to add interfaces to JIT. Interfaces allow the specification through a blank python class of an abstract interface that can be used in type annotations for Script functions. If a TorchScript class implements all the methods in the interface with the appropriate types, then it is implicitly considered to implement that interface. Follows required: * implementation of serialization * implementation in the parser frontend * better error reporting for explaining why a class does not meet an interface specification. gh-metadata: pytorch pytorch 21853 gh/zdevito/66/head
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary: this is the first commit in a series to add interfaces to JIT.
Interfaces allow the specification through a blank python class of an
abstract interface that can be used in type annotations for Script functions.
If a TorchScript class implements all the methods in the interface with
the appropriate types, then it is implicitly considered to implement
that interface.
Follows required:
interface specification.
Differential Revision: D15850612