[jit] improve recursive scripting error message #21841
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We try to grab the __code__ attribute, which doesn't work for classes. Add a better error message in this case
[jit] improve recursive scripting error message We try to grab the __code__ attribute, which doesn't work for classes. Add a better error message in this case gh-metadata: pytorch pytorch 21841 gh/suo/62/head
zdevito
approved these changes
Jun 17, 2019
Contributor
zdevito
left a comment
zdevito
left a comment
There was a problem hiding this comment.
Seems fine, but the error message doesn't say what the fn is if not a function and we got there. Also why is it valid to ask for __name__ of a random object?
[jit] improve recursive scripting error message We try to grab the __code__ attribute, which doesn't work for classes. Add a better error message in this case gh-metadata: pytorch pytorch 21841 gh/suo/62/head
[jit] improve recursive scripting error message We try to grab the __code__ attribute, which doesn't work for classes. Add a better error message in this case gh-metadata: pytorch pytorch 21841 gh/suo/62/head
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
We try to grab the code attribute, which doesn't work for classes.
Add a better error message in this case
Differential Revision: D15857569