handle slice with negative indices and indices exceeding tensor dimen… #21811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytorchbot
added
oncall: jit
zhangguanheng66
added
the
triaged
spandantiwari
suggested changes
Jun 19, 2019
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
houseroad
approved these changes
Jun 21, 2019
| _set_opset_version(9) | ||
| x = torch.ones(1, 3) | ||
| graph, _, __ = utils._model_to_graph(SliceModule(), (x, ), | ||
| graph, _, __ = utils._model_to_graph(NarrowModule(), (x, ), |
Member
There was a problem hiding this comment.
nit: __ => _
also can you change all the __ to _?
| int64_t length = end - start; | ||
| if (length < 0 || start > updated_val.sizes()[axis] - length) | ||
| return c10::nullopt; | ||
| updated_val = at::narrow(updated_val, axis, start, length); |
Member
There was a problem hiding this comment.
you may also want to try at::slice
Member
|
will merge this pr first, feel free to open another pr to address nits. |
Contributor
|
@houseroad merged this pull request in f9b3989. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
handle slice with negative indices and indices exceeding tensor dimensions.