Skip to content

[tensorboard] Cleanup API and remove 'experimental' warning #21786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
orionr wants to merge 6 commits into from
Closed

[tensorboard] Cleanup API and remove 'experimental' warning #21786

orionr wants to merge 6 commits into from

Conversation

@orionr
Copy link
Contributor

@orionr orionr commented Jun 14, 2019

This cleans up the torch.utils.tensorboard API to remove all kwargs usage (which isn't clear to the user) and removes the "experimental" warning in prep for our 1.2 release.

We also don't need the additional PyTorch version checks now that we are in the codebase itself.

cc @ezyang @lanpa @natalialunova

@pytorchbot pytorchbot added the module: docs Related to our documentation, both in docs/ and docblocks label Jun 14, 2019
facebook-github-bot
facebook-github-bot reviewed Jun 17, 2019
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@orionr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@nataliakliushkina
Copy link
Contributor

nataliakliushkina commented Jun 17, 2019

Looks good!

lanpa
lanpa reviewed Jun 18, 2019
View reviewed changes
@pytorchbot pytorchbot added the module: tests Issues related to tests (not the torch.testing module) label Jul 3, 2019
@orionr
Copy link
Contributor Author

orionr commented Jul 12, 2019

@pytorchbot retest this please

facebook-github-bot
facebook-github-bot reviewed Jul 12, 2019
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@orionr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@orionr orionr force-pushed the remove-tensorboard-experimental branch from 252b317 to 7b8253c Compare July 15, 2019 20:20
facebook-github-bot
facebook-github-bot reviewed Jul 15, 2019
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@orionr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@orionr orionr force-pushed the remove-tensorboard-experimental branch from 7b8253c to 9d75eb9 Compare July 16, 2019 14:54
@orionr orionr force-pushed the remove-tensorboard-experimental branch from 86e3694 to b957e96 Compare July 16, 2019 23:49
@orionr
Copy link
Contributor Author

orionr commented Jul 17, 2019

@pytorchbot retest this please

1 similar comment
@orionr
Copy link
Contributor Author

orionr commented Jul 17, 2019

@pytorchbot retest this please

facebook-github-bot
facebook-github-bot reviewed Jul 17, 2019
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@orionr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@orionr
Copy link
Contributor Author

orionr commented Jul 17, 2019

Tests passed even though not updated in GitHub UI.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 17, 2019

@orionr merged this pull request in 4861527.

@orionr orionr mentioned this pull request Jul 17, 2019
Closed
@ailzhang
Copy link
Contributor

ailzhang commented Jul 17, 2019

FYI this PR might have broken asan test.

@orionr
Copy link
Contributor Author

orionr commented Jul 17, 2019

Unfortunately looks like it. We can revert (and re-land) or wait to see if #23000 fixes it.

@orionr
Copy link
Contributor Author

orionr commented Jul 17, 2019

Actually, looks like there are other issues, so reverting.

salexspb pushed a commit to salexspb/pytorch that referenced this pull request Jul 22, 2019
@orionr @facebook-github-bot
Cleanup API and remove 'experimental' warning (pytorch#23000)
858d4a6 
Summary:
This fixes ASAN test issues with pytorch#21786 seen at https://circleci.com/api/v1.1/project/github/pytorch/pytorch/2212325/output/105/0?file=true and lands it again.

This cleans up the `torch.utils.tensorboard` API to remove all kwargs usage (which isn't clear to the  user) and removes the "experimental" warning in prep for our 1.2 release.

We also don't need the additional PyTorch version checks now that we are in the codebase itself.

cc yf225, lanpa, natalialunova
Pull Request resolved: pytorch#23000

Reviewed By: sanekmelnikov

Differential Revision: D16349734

Pulled By: orionr

fbshipit-source-id: 604a9cad56868a55e08b509a0c6f42b84f68de95
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lanpa lanpa lanpa left review comments

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

Assignees

No one assigned

Labels

Merged module: docs Related to our documentation, both in docs/ and docblocks module: tests Issues related to tests (not the torch.testing module)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@orionr @nataliakliushkina @facebook-github-bot @ailzhang @lanpa @pytorchbot @mruberry