Allow batch sizes > 65535 for inverse, solve, cholesky_solve and tria… #21689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ngular_solve Changelog: - Iterate over mini batches of 65535 matrices (maximum) Test Plan: - Added slow tests to test the behavior in test_torch and test_cuda
pytorchbot
added
module: cuda
Contributor
Author
soumith
approved these changes
Jun 12, 2019
Contributor
|
test failures are legit |
Contributor
Author
|
@soumith all CUDA tests pass. |
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@soumith is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
|
thank you! |
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jun 13, 2019
…… (#21689) Summary: …ngular_solve Changelog: - Iterate over mini batches of 65535 matrices (maximum) Pull Request resolved: pytorch/pytorch#21689 Differential Revision: D15800254 Pulled By: soumith fbshipit-source-id: c743ff13f1ba25d26874429d44e41a3c0ed21d6a
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ngular_solve
Changelog:
Test Plan:
Fixes #21643 and fixes #13276