Define __setstate__ on _ConvNd to handle pre-padding_mode pickles. #21687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #20756 Signed-off-by: Edward Z. Yang <[email protected]>
Contributor
Author
|
I have a test case but it is blocked on getting access to our AWS bucket so I can upload the test data. |
pietern
approved these changes
Jun 12, 2019
Contributor
pietern
left a comment
pietern
left a comment
There was a problem hiding this comment.
LGTM! If the none constant is defined elsewhere (perhaps even as default) then you could use that?
…pickles." Define __setstate__ on _ConvNd to handle pre-padding_mode pickles. Fixes #20756 Signed-off-by: Edward Z. Yang <[email protected]> gh-metadata: pytorch pytorch 21687 gh/ezyang/167/head
…pickles." Define __setstate__ on _ConvNd to handle pre-padding_mode pickles. Fixes #20756 Signed-off-by: Edward Z. Yang <[email protected]> gh-metadata: pytorch pytorch 21687 gh/ezyang/167/head
…handle pre-padding_mode pickles." Define __setstate__ on _ConvNd to handle pre-padding_mode pickles. Fixes #20756 Signed-off-by: Edward Z. Yang <[email protected]> gh-metadata: pytorch pytorch 21687 gh/ezyang/167/head
…handle pre-padding_mode pickles." Define __setstate__ on _ConvNd to handle pre-padding_mode pickles. Fixes #20756 Signed-off-by: Edward Z. Yang <[email protected]> gh-metadata: pytorch pytorch 21687 gh/ezyang/167/head
…pickles." Define __setstate__ on _ConvNd to handle pre-padding_mode pickles. Fixes #20756 Signed-off-by: Edward Z. Yang <[email protected]> gh-metadata: pytorch pytorch 21687 gh/ezyang/167/head
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Fixes #20756
Signed-off-by: Edward Z. Yang [email protected]
Differential Revision: D15807402