Make script::Method a value type #21675
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that modules are always first class, a Method is simply a pair of Function and Method object. It is no longer necessary to have a reified table of Methods and removes the need for locking.
This was referenced Jun 12, 2019
Make script::Method a value type Now that modules are always first class, a Method is simply a pair of Function and Method object. It is no longer necessary to have a reified table of Methods and removes the need for locking. gh-metadata: pytorch pytorch 21675 gh/zdevito/64/head
Make script::Method a value type Now that modules are always first class, a Method is simply a pair of Function and Method object. It is no longer necessary to have a reified table of Methods and removes the need for locking. gh-metadata: pytorch pytorch 21675 gh/zdevito/64/head
Make script::Method a value type Now that modules are always first class, a Method is simply a pair of Function and Method object. It is no longer necessary to have a reified table of Methods and removes the need for locking. gh-metadata: pytorch pytorch 21675 gh/zdevito/64/head
Make script::Method a value type Now that modules are always first class, a Method is simply a pair of Function and Method object. It is no longer necessary to have a reified table of Methods and removes the need for locking. gh-metadata: pytorch pytorch 21675 gh/zdevito/64/head
suo
approved these changes
Jun 13, 2019
| // can be removed as well | ||
| get_offset(name, EntityType::METHOD); | ||
| AT_ERROR("unreachable"); | ||
| AT_ERROR("Method '", name, "' is not defined."); |
Member
There was a problem hiding this comment.
Let's swap this out for one of the new error methods while we're here
torch/csrc/jit/script/module.h
Outdated
| const std::vector<Method> get_methods() const { | ||
| return fmap(class_compilation_unit().get_functions(), | ||
| [&](const std::shared_ptr<Function> &func) { | ||
| return Method(const_cast<Module *>(this), func); |
Member
There was a problem hiding this comment.
Can we remove this const_cast? It's not clear to me why methods need a mutable reference to their owner anyway
Make script::Method a value type Now that modules are always first class, a Method is simply a pair of Function and Method object. It is no longer necessary to have a reified table of Methods and removes the need for locking. gh-metadata: pytorch pytorch 21675 gh/zdevito/64/head
Make script::Method a value type Now that modules are always first class, a Method is simply a pair of Function and Method object. It is no longer necessary to have a reified table of Methods and removes the need for locking. gh-metadata: pytorch pytorch 21675 gh/zdevito/64/head
Make script::Method a value type Now that modules are always first class, a Method is simply a pair of Function and Method object. It is no longer necessary to have a reified table of Methods and removes the need for locking. gh-metadata: pytorch pytorch 21675 gh/zdevito/64/head
Make script::Method a value type Now that modules are always first class, a Method is simply a pair of Function and Method object. It is no longer necessary to have a reified table of Methods and removes the need for locking. gh-metadata: pytorch pytorch 21675 gh/zdevito/64/head
Make script::Method a value type Now that modules are always first class, a Method is simply a pair of Function and Method object. It is no longer necessary to have a reified table of Methods and removes the need for locking. gh-metadata: pytorch pytorch 21675 gh/zdevito/64/head
Make script::Method a value type Now that modules are always first class, a Method is simply a pair of Function and Method object. It is no longer necessary to have a reified table of Methods and removes the need for locking. gh-metadata: pytorch pytorch 21675 gh/zdevito/64/head
Make script::Method a value type Now that modules are always first class, a Method is simply a pair of Function and Method object. It is no longer necessary to have a reified table of Methods and removes the need for locking. gh-metadata: pytorch pytorch 21675 gh/zdevito/64/head
Make script::Method a value type Now that modules are always first class, a Method is simply a pair of Function and Method object. It is no longer necessary to have a reified table of Methods and removes the need for locking. gh-metadata: pytorch pytorch 21675 gh/zdevito/64/head
This was referenced Jun 17, 2019
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Now that modules are always first class, a Method is simply a pair
of Function and Method object. It is no longer necessary to have
a reified table of Methods and removes the need for locking.
Differential Revision: D15777725