[JIT] Override print when python is present #21625
Conversation
pytorchbot
added
caffe2
oncall: jit
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@jamesr66a has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
| namespace torch { | ||
| namespace jit { | ||
|
|
||
| using PrintHandler = void (*)(const std::string&); |
torch/csrc/jit/init.cpp
Outdated
| // WriteStdout will truncate to 1000 bytes. | ||
| // auto _stdout = py::module::import("sys").attr("stdout"); | ||
| // _stdout.attr("write")(_stdout, str); | ||
| PySys_WriteStdout("%s", str.c_str()); |
There was a problem hiding this comment.
can we not just call print through pybind?
There was a problem hiding this comment.
I can't get it to not complain that it expects bytes, not str, even if i explicitly cast to py::bytes. something seems broken there in pybind
jamesr66a
force-pushed
the
override_stdout
branch
from
ab38165 to
d089ea3
Compare
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@jamesr66a has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
jamesr66a
force-pushed
the
override_stdout
branch
from
dd56ec0 to
90c0674
Compare
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@jamesr66a has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@jamesr66a has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@jamesr66a is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@jamesr66a merged this pull request in c2a18a6. |
6 participants
This makes it so we can see the output of prim::Print in environments like iPython notebooks which override sys.stdout