Skip to content

numerical integration "trapz" function. #21610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
umanwizard wants to merge 13 commits into from
Closed

numerical integration "trapz" function. #21610

umanwizard wants to merge 13 commits into from

Conversation

@umanwizard
Copy link
Contributor

@umanwizard umanwizard commented Jun 10, 2019

This is intended to match numpy.trapz: numerical integration based on the trapezoid rule.

facebook-github-bot
facebook-github-bot reviewed Jun 10, 2019
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@umanwizard has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

zou3519
zou3519 reviewed Jun 11, 2019
View reviewed changes
zou3519
zou3519 reviewed Jun 11, 2019
View reviewed changes
gchanan
gchanan reviewed Jun 11, 2019
View reviewed changes
gchanan
gchanan reviewed Jun 11, 2019
View reviewed changes
gchanan
gchanan reviewed Jun 11, 2019
View reviewed changes
Copy link
Contributor

@gchanan gchanan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this work on cuda? (test?).

@pytorchbot pytorchbot added the module: docs Related to our documentation, both in docs/ and docblocks label Jun 11, 2019
Brennan Vincent added 2 commits June 11, 2019 11:13
@umanwizard umanwizard requested review from gchanan and zou3519 June 11, 2019 18:19
facebook-github-bot
facebook-github-bot reviewed Jun 11, 2019
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@umanwizard has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

gchanan
gchanan reviewed Jun 11, 2019
View reviewed changes
@umanwizard umanwizard requested a review from gchanan June 11, 2019 19:29
facebook-github-bot
facebook-github-bot reviewed Jun 11, 2019
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@umanwizard has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

zou3519
zou3519 reviewed Jun 11, 2019
View reviewed changes
zou3519
zou3519 reviewed Jun 11, 2019
View reviewed changes
zou3519
zou3519 reviewed Jun 11, 2019
View reviewed changes
zou3519
zou3519 reviewed Jun 11, 2019
View reviewed changes
zou3519
zou3519 reviewed Jun 11, 2019
View reviewed changes
fmassa
fmassa reviewed Jun 11, 2019
View reviewed changes
@pytorchbot pytorchbot added the module: autograd Related to torch.autograd, and the autograd engine in general label Jun 11, 2019
@umanwizard umanwizard requested review from fmassa and zou3519 June 11, 2019 22:40
facebook-github-bot
facebook-github-bot reviewed Jun 11, 2019
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@umanwizard has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

zou3519
zou3519 reviewed Jun 12, 2019
View reviewed changes
@umanwizard
Copy link
Contributor Author

umanwizard commented Jun 12, 2019

@pytorchbot rebase this please

zou3519
zou3519 approved these changes Jun 12, 2019
View reviewed changes
Copy link
Contributor

@zou3519 zou3519 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

facebook-github-bot
facebook-github-bot reviewed Jun 12, 2019
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@umanwizard has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

zdevito pushed a commit to zdevito/ATen that referenced this pull request Jun 12, 2019
@facebook-github-bot
numerical integration "trapz" function. (#21610)
ae94b7d 
Summary:
This is intended to match [numpy.trapz](https://docs.scipy.org/doc/numpy/reference/generated/numpy.trapz.html): numerical integration based on the trapezoid rule.
Pull Request resolved: pytorch/pytorch#21610

Differential Revision: D15747618

Pulled By: umanwizard

fbshipit-source-id: 8eadb2e75c9877b07592d875ca0b2cca6cb72297
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 13, 2019

@umanwizard merged this pull request in 699de48.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@zou3519 zou3519 zou3519 approved these changes

@colesbury colesbury Awaiting requested review from colesbury

@ifedan ifedan Awaiting requested review from ifedan

@gchanan gchanan Awaiting requested review from gchanan

@fmassa fmassa Awaiting requested review from fmassa

Assignees

No one assigned

Labels

Merged module: autograd Related to torch.autograd, and the autograd engine in general module: docs Related to our documentation, both in docs/ and docblocks

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@umanwizard @facebook-github-bot @gchanan @zou3519 @fmassa @pytorchbot @mruberry