[jit] Add Final[T] annotated members to __constants__
#21603
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Class member annotations can be marked with `Final[T]` instead of adding them to `__constants__`. `Final` comes from the `typing_extensions` module (which will be used if it is present). If not, the polyfill from `_jit_internal` is exposed as `torch.jit.Final` for users that don't want to install `typing_extensions`. This keeps around `__constants__` since a lot of code is still using it, but in documentation follow ups we should change it all to use `Final`.
added 2 commits
June 12, 2019 12:58
suo
reviewed
Jun 12, 2019
| @unittest.skipIf(PY2, "Class annotations are a thing in > 3.5") | ||
| def test_constants_with_final(self): | ||
| class M(torch.nn.Module): | ||
| # TODO: Use this (see below) |
Contributor
Author
There was a problem hiding this comment.
This is Python 3 only syntax, including it in this test makes all the Python2 tests fail to parse the file
suo
approved these changes
Jun 12, 2019
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Class member annotations can be marked with
Final[T]instead of adding them to__constants__.Finalcomes from thetyping_extensionsmodule (which will be used if it is present). If not, the polyfill from_jit_internalis exposed astorch.jit.Finalfor users that don't want to installtyping_extensions.This keeps around
__constants__since a lot of code is still using it, but in documentation follow ups we should change the examples to all to useFinal.TODO: install typing_extensions on CI, move tests to a Python3 only file when #21489 lands
Differential Revision: D15746274