Skip to content

Document the Boolean tensor type. #21601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
xuhdev wants to merge 1 commit into from
Closed

Document the Boolean tensor type. #21601

xuhdev wants to merge 1 commit into from

Conversation

@xuhdev
Copy link
Collaborator

@xuhdev xuhdev commented Jun 10, 2019

No description provided.

@pytorchbot pytorchbot added the module: docs Related to our documentation, both in docs/ and docblocks label Jun 10, 2019
@xuhdev xuhdev force-pushed the doc/dtype branch 2 times, most recently from 1aee834 to d9ed134 Compare June 13, 2019 18:49
@gchanan gchanan self-requested a review June 13, 2019 23:13
gchanan
gchanan reviewed Jun 13, 2019
View reviewed changes
docs/source/tensors.rst Outdated
Copy link
Contributor

@gchanan gchanan Jun 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can you lower case "Boolean".

Copy link
Collaborator Author

@xuhdev xuhdev Jun 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the most common appearance is with a capitalized B? (for example, Wikipedia and Merriam Webster)

Copy link
Contributor

@gchanan gchanan Jun 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only suggested that because integer and floating point are lower cased.

Copy link
Collaborator Author

@xuhdev xuhdev Jun 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, because "integer" and "floating point" are correct spelling when they are lowercased, but "boolean" is generally deemed as incorrect spelling. Imagine we have a table of ["you", "they", "I"], we don't lowercase the "I".

But I can still make the change if it's important to use lowercased 'b' here. Please advise.

@gchanan gchanan added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jun 13, 2019
@xuhdev xuhdev force-pushed the doc/dtype branch 3 times, most recently from c8bc2c6 to 46f0723 Compare June 14, 2019 18:00
@xuhdev xuhdev requested a review from gchanan June 24, 2019 17:51
facebook-github-bot
facebook-github-bot reviewed Jun 24, 2019
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gchanan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@xuhdev xuhdev deleted the doc/dtype branch June 24, 2019 21:36
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 24, 2019

@gchanan merged this pull request in a458989.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@gchanan gchanan gchanan approved these changes

Assignees

No one assigned

Labels

Merged module: docs Related to our documentation, both in docs/ and docblocks open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@xuhdev @facebook-github-bot @gchanan @ezyang @pytorchbot @mruberry