fix segfault in cat on CPU with tensors that can't be indexed with 32-bit ints.
#21530
Conversation
pytorchbot
added
module: cpu
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@umanwizard has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
| def test_cat_empty(self): | ||
| self._test_cat_empty(self) | ||
|
|
||
| def test_cat_big(self): |
There was a problem hiding this comment.
Should this test be marked as slow or something like that? Also, how much memory does it need, > 2GB?
There was a problem hiding this comment.
@fmassa The test needs 5 GB and takes about 8 seconds on my machine. Do you know if there is a good way to mark tests as not running in memory-constrained environments?
Alternatively we can just land this without the test. What do you think?
There was a problem hiding this comment.
I think we should have the test. Maybe at some point in the future we might consider adding a flag for memory intensive tests, both on the cpu and you
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@umanwizard has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
At any rate, I'll make sure none of our internal tests barf on this before landing. |
…32-bit ints. (#21530) Summary: Should be self-explanatory. This `int` variable is overflowing. Reported in #21526 Pull Request resolved: pytorch/pytorch#21530 Differential Revision: D15719275 Pulled By: umanwizard fbshipit-source-id: 24e917a00a5b78bc3af29ef3b8b72eea7e89d5d5
|
@umanwizard merged this pull request in 74828be. |
6 participants
Should be self-explanatory. This
intvariable is overflowing.Reported in #21526