Enabled BFloat16 storage #21523
Closed
Enabled BFloat16 storage #21523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytorchbot
added
module: build
Enabled BFloat16 storage gh-metadata: pytorch pytorch 21523 gh/izdeby/9/head
Enabled BFloat16 storage gh-metadata: pytorch pytorch 21523 gh/izdeby/9/head
gchanan
requested changes
Jun 7, 2019
Enabled BFloat16 storage gh-metadata: pytorch pytorch 21523 gh/izdeby/9/head
ezyang
reviewed
Jun 11, 2019
Contributor
|
This LGTM. I'll let Greg do final approval |
gchanan
requested changes
Jun 11, 2019
Contributor
gchanan
left a comment
gchanan
left a comment
There was a problem hiding this comment.
testing? I'm presuming we have tests for bool around conversion, moving to cuda and back, etc. We should have those here.
Enabled BFloat16 storage gh-metadata: pytorch pytorch 21523 gh/izdeby/9/head
gchanan
approved these changes
Jun 12, 2019
Enabled BFloat16 storage gh-metadata: pytorch pytorch 21523 gh/izdeby/9/head
Enabled BFloat16 storage gh-metadata: pytorch pytorch 21523 gh/izdeby/9/head
Enabled BFloat16 storage gh-metadata: pytorch pytorch 21523 gh/izdeby/9/head
Enabled BFloat16 storage gh-metadata: pytorch pytorch 21523 gh/izdeby/9/head
Enabled BFloat16 storage gh-metadata: pytorch pytorch 21523 gh/izdeby/9/head
Enabled BFloat16 storage gh-metadata: pytorch pytorch 21523 gh/izdeby/9/head
Enabled BFloat16 storage gh-metadata: pytorch pytorch 21523 gh/izdeby/9/head
Enabled BFloat16 storage gh-metadata: pytorch pytorch 21523 gh/izdeby/9/head
Enabled BFloat16 storage gh-metadata: pytorch pytorch 21523 gh/izdeby/9/head
Enabled BFloat16 storage gh-metadata: pytorch pytorch 21523 gh/izdeby/9/head
Enabled BFloat16 storage gh-metadata: pytorch pytorch 21523 gh/izdeby/9/head
|
I am curious if this is currently being gated by just the two build failures above or even a reviewer. |
Contributor
|
@soumyarooproy i think Iurii will land this along with other BFloat16 diffs at once. If you see the PR description (the first comment), this is a stack of diffs that he is building up. |
Enabled BFloat16 storage gh-metadata: pytorch pytorch 21523 gh/izdeby/9/head
This was referenced Jul 9, 2019
Closed
Enabled BFloat16 storage gh-metadata: pytorch pytorch 21523 gh/izdeby/9/head
Contributor
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jul 10, 2019
Summary: Pull Request resolved: pytorch/pytorch#21523 ghimport-source-id: 698b3cbd6b21c09b9ff8bf8011980df8e35c33b0 Test Plan: Imported from OSS Differential Revision: D15819368 Pulled By: izdeby fbshipit-source-id: f6b3bba7b3ca8ee677bd80a231dbb3920c07d61c
|
Thanks for adding this! I'm having trouble using it from the python API. Have we not yet implemented casting to and from |
Contributor
Author
|
Hey, @nottombrown, what are you trying to do? i added conversion method in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Enabled storage to support BFloat16 type.
Tested via unit tests
Differential Revision: D15819368