Add mkldnn softmax operator #21516
Closed
Add mkldnn softmax operator #21516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytorchbot
added
module: mkldnn
bddppq
commented
Jun 7, 2019
| namespace native { | ||
|
|
||
| namespace { | ||
| // TODO: move this to ideep |
Contributor
Author
There was a problem hiding this comment.
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@bddppq has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
gchanan
approved these changes
Jun 7, 2019
Contributor
gchanan
left a comment
gchanan
left a comment
There was a problem hiding this comment.
would be good to have an MKLDNN person look at those details.
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@bddppq has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
Author
|
@Jianhui-Li @XiaobingSuper @gujinghui Mind taking a look at the |
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jun 7, 2019
Summary: Pull Request resolved: pytorch/pytorch#21516 Differential Revision: D15712759 Pulled By: bddppq fbshipit-source-id: bf515135263156bea1a2b3e53a47edf697b8b1e2
Contributor
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.