clean up the TracingState API #21514
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes sure the API always works on IValues (previously a mix of IValue/Variable/Tensor). It removes some unnecessary functions (NestedOutput vs Output) and makes frames a private concept inside tracing state.
This was referenced Jun 7, 2019
clean up the TracingState API This makes sure the API always works on IValues (previously a mix of IValue/Variable/Tensor). It removes some unnecessary functions (NestedOutput vs Output) and makes frames a private concept inside tracing state. gh-metadata: pytorch pytorch 21514 gh/zdevito/50/head
clean up the TracingState API This makes sure the API always works on IValues (previously a mix of IValue/Variable/Tensor). It removes some unnecessary functions (NestedOutput vs Output) and makes frames a private concept inside tracing state. gh-metadata: pytorch pytorch 21514 gh/zdevito/50/head
clean up the TracingState API This makes sure the API always works on IValues (previously a mix of IValue/Variable/Tensor). It removes some unnecessary functions (NestedOutput vs Output) and makes frames a private concept inside tracing state. gh-metadata: pytorch pytorch 21514 gh/zdevito/50/head
suo
approved these changes
Jun 7, 2019
clean up the TracingState API This makes sure the API always works on IValues (previously a mix of IValue/Variable/Tensor). It removes some unnecessary functions (NestedOutput vs Output) and makes frames a private concept inside tracing state. gh-metadata: pytorch pytorch 21514 gh/zdevito/50/head
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This makes sure the API always works on IValues (previously a mix of IValue/Variable/Tensor).
It removes some unnecessary functions (NestedOutput vs Output) and makes frames a private concept
inside tracing state.
Differential Revision: D15719980