Collapse tracing_state.h into tracer.h #21513
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Whatever reasons for the separation originally, almost everywhere just includes tracer.h now, making the distinction confusing. This just collapses them to a single file.
pytorchbot
added
oncall: jit
This was referenced Jun 7, 2019
suo
approved these changes
Jun 7, 2019
Member
suo
left a comment
suo
left a comment
There was a problem hiding this comment.
accepting assuming the changes are mechanical
Collapse tracing_state.h into tracer.h Summary: Whatever reasons for the separation originally, almost everywhere just includes tracer.h now, making the distinction confusing. This just collapses them to a single file. gh-metadata: pytorch pytorch 21513 gh/zdevito/49/head
Collapse tracing_state.h into tracer.h Summary: Whatever reasons for the separation originally, almost everywhere just includes tracer.h now, making the distinction confusing. This just collapses them to a single file. gh-metadata: pytorch pytorch 21513 gh/zdevito/49/head
Collapse tracing_state.h into tracer.h Summary: Whatever reasons for the separation originally, almost everywhere just includes tracer.h now, making the distinction confusing. This just collapses them to a single file. gh-metadata: pytorch pytorch 21513 gh/zdevito/49/head
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary: Whatever reasons for the separation originally, almost
everywhere just includes tracer.h now, making the distinction confusing.
This just collapses them to a single file.
Differential Revision: D15719982