Skip to content

Conversation

@Chillee
Copy link
Collaborator

@Chillee Chillee commented Jun 7, 2019

Stack from ghstack:

Differential Revision: D16088191

@pytorchbot pytorchbot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Jun 7, 2019
Chillee added 11 commits June 6, 2019 22:15
Added math.log2 and hypot

gh-metadata: pytorch pytorch 21512 gh/chillee/36/head
Added math.log2 and hypot

gh-metadata: pytorch pytorch 21512 gh/chillee/36/head
Added math.log2 and hypot

gh-metadata: pytorch pytorch 21512 gh/chillee/36/head
Added math.log2 and hypot

gh-metadata: pytorch pytorch 21512 gh/chillee/36/head
Added math.log2 and hypot

gh-metadata: pytorch pytorch 21512 gh/chillee/36/head
Added math.log2 and hypot

gh-metadata: pytorch pytorch 21512 gh/chillee/36/head
Added math.log2 and hypot

gh-metadata: pytorch pytorch 21512 gh/chillee/36/head
Added math.log2 and hypot

gh-metadata: pytorch pytorch 21512 gh/chillee/36/head
Added math.log2 and hypot

gh-metadata: pytorch pytorch 21512 gh/chillee/36/head
Added math.log2 and hypot

gh-metadata: pytorch pytorch 21512 gh/chillee/36/head
Added math.log2 and hypot

gh-metadata: pytorch pytorch 21512 gh/chillee/36/head
@Chillee Chillee requested review from ailzhang and jamesr66a June 10, 2019 23:40
Copy link
Collaborator

@jamesr66a jamesr66a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@ailzhang
Copy link
Contributor

Oh in fact, you might need to rebase this on top of master before landing. I think I used hypot as the one to test out "unsupported function" error message. And that got merged 1-2 days ago. #21068 You might want to change it to another rarely used function instead. Thanks!

Chillee added 11 commits June 27, 2019 17:30
Added math.log2 and hypot

gh-metadata: pytorch pytorch 21512 gh/chillee/36/head
Added math.log2 and hypot

gh-metadata: pytorch pytorch 21512 gh/chillee/36/head
Added math.log2 and hypot

gh-metadata: pytorch pytorch 21512 gh/chillee/36/head
Added math.log2 and hypot

gh-metadata: pytorch pytorch 21512 gh/chillee/36/head
Added math.log2 and hypot

gh-metadata: pytorch pytorch 21512 gh/chillee/36/head
Added math.log2 and hypot

gh-metadata: pytorch pytorch 21512 gh/chillee/36/head
Added math.log2 and hypot

gh-metadata: pytorch pytorch 21512 gh/chillee/36/head
Added math.log2 and hypot

gh-metadata: pytorch pytorch 21512 gh/chillee/36/head
Added math.log2 and hypot

gh-metadata: pytorch pytorch 21512 gh/chillee/36/head
Added math.log2 and hypot

gh-metadata: pytorch pytorch 21512 gh/chillee/36/head
Added math.log2 and hypot

gh-metadata: pytorch pytorch 21512 gh/chillee/36/head
@zou3519 zou3519 deleted the gh/chillee/36/head branch July 2, 2019 13:31
@facebook-github-bot
Copy link
Contributor

@Chillee merged this pull request in b768777.

xzhu1900 pushed a commit to xzhu1900/pytorch that referenced this pull request Jul 5, 2019
Summary: Pull Request resolved: pytorch#21512

Test Plan: Imported from OSS

Differential Revision: D16088191

Pulled By: Chillee

fbshipit-source-id: 5d80c480243d2644c96df26337cf65918d79443e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merged oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants