Fix size of histc return on CPU when input is 0-dimensional and bins=1. #21497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This triggers the wrong scalar_check unless it is explicitly overridden (because the heuristic uses the shape of the input). This wasn't an issue on CUDA because it didn't use TH, so doesn't have scalar checks.
pytorchbot
added
module: internals
This was referenced Jun 6, 2019
zou3519
approved these changes
Jun 6, 2019
Contributor
zou3519
left a comment
zou3519
left a comment
There was a problem hiding this comment.
lgtm, thanks for catching this
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jun 7, 2019
…1. (#21497) Summary: Pull Request resolved: pytorch/pytorch#21497 ghimport-source-id: bc03f27408aa772f78d5351afe404b5e91a7c4ce Differential Revision: D15715478 Pulled By: gchanan fbshipit-source-id: 90e1b65249b4b12f936ee8877cc0bc5a972d9ceb
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This triggers the wrong scalar_check unless it is explicitly overridden (because the heuristic uses the shape of the input).
This wasn't an issue on CUDA because it didn't use TH, so doesn't have scalar checks.
Differential Revision: D15715478