Set "scalar_check: false" for TH methods that can't return scalars. #21496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The goal here is to eventually get rid of maybe_zero_dim.
pytorchbot
added
the
module: internals
This was referenced Jun 6, 2019
yf225
approved these changes
Jun 7, 2019
Contributor
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jun 7, 2019
…#21496) Summary: Pull Request resolved: pytorch/pytorch#21496 ghimport-source-id: d7197bccfe9e4d807f38a66e02ca6f0bf32bdc2b Differential Revision: D15715479 Pulled By: gchanan fbshipit-source-id: fa59eb808d26119b33eb97bb90ef70e95e58458d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
The goal here is to eventually get rid of maybe_zero_dim.
Differential Revision: D15715479