[jit] Move Python 3 tests to their own file #21489
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 6, 2019 14:20
pytorchbot
added
module: pybind
eellison
reviewed
Jun 6, 2019
|
|
||
|
|
||
| @unittest.skipIf(PY2, "tuple printing in py2 is different than torchscript") | ||
| def test_string_print(self): |
Contributor
Author
There was a problem hiding this comment.
| self.assertExpected(str(ast)) | ||
|
|
||
| @unittest.skipIf(PY2, "Requires python 3") | ||
| def test_python_frontend_py3(self): |
Contributor
Author
There was a problem hiding this comment.
| @unittest.skipIf(not PY35, "Python 3.5 needed") | ||
| def test_matmul_py3(self): | ||
| code = dedent(""" | ||
| def fn(a, b): |
Contributor
Author
There was a problem hiding this comment.
it's moved, the _py3 was removed
added 2 commits
June 10, 2019 18:22
eellison
reviewed
Jun 11, 2019
| pass | ||
|
|
||
|
|
||
| def check_test_defined_in_running_script(test_case): |
eellison
approved these changes
Jun 11, 2019
Contributor
eellison
left a comment
eellison
left a comment
There was a problem hiding this comment.
Looks good but i think you need FBCode changes so the test runs internally
suo
approved these changes
Jun 11, 2019
Contributor
|
The assert exists because people sometimes imported |
ezyang
requested changes
Jun 11, 2019
Contributor
ezyang
left a comment
ezyang
left a comment
There was a problem hiding this comment.
Please figure out why the assert was twinging.
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 12, 2019
Summary: Class member annotations can be marked with `Final[T]` instead of adding them to `__constants__`. `Final` comes from the `typing_extensions` module (which will be used if it is present). If not, the polyfill from `_jit_internal` is exposed as `torch.jit.Final` for users that don't want to install `typing_extensions`. This keeps around `__constants__` since a lot of code is still using it, but in documentation follow ups we should change the examples to all to use `Final`. TODO: install typing_extensions on CI, move tests to a Python3 only file when #21489 lands ](https://our.intern.facebook.com/intern/diff/15746274/) Pull Request resolved: #21603 Pulled By: driazati Differential Revision: D15746274 fbshipit-source-id: d2c9b5643b4abba069b130c26fd42714c906ffac
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keeping them in their own file lets us use Python3 syntax directly instead of going through the string frontend
This also deletes an assert added in #13250, cc @ezyang do you know why this check was added in the first place?
The test cases defined outside
test_jit.pywork fine with Python's unittest runner. Pytest doesn't find them though, so to use Pytest for those files you have to run the file directly instead of doingpytest test_jit.pyDifferential Revision: D15704079