[ONNX] Fix the shape of PReLU weight #21330
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@ezyang @houseroad Could you please help review it? Thanks! |
houseroad
reviewed
Jun 12, 2019
houseroad
reviewed
Jun 12, 2019
torch/onnx/symbolic_opset9.py
Outdated
| def prelu(g, self, weight): | ||
| self_sizes = self.type().sizes() | ||
| if self_sizes and len(self_sizes) > 2: | ||
| weight = g.op("Unsqueeze", weight, axes_i=list(range(1, len(self_sizes) - 1))) |
Member
There was a problem hiding this comment.
also we already supported the broadcasting in ONNX's PRelu, why do we want to unsqueeze it again?
Contributor
Author
There was a problem hiding this comment.
The reason is #21271. The shape of weight should be [channels, 1, 1] according to ONNX document (ONNX PReLU requires unidirectional broadcasting), however, the actual shape is [channels] instead.
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
|
@houseroad merged this pull request in 76e0154. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #21271