Interpreter support for CallFunction/CallMethod #21325
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Adds CALL instruction, and function_table to interpreter state. Interpreter state now has a list of Frame objects to keep track of active call frames. Nodes: * Re-did how exception wrapping works so that call stacks can be printed by the interpreter. * Change the order of error reporting so that it is more clear what part of a printout is attributable to the interpreter or shape prop adding additional context to an error. * The first-class functions are only enabled under a guard because serialization does not work and more tests need to be added for the funnctionality.
pytorchbot
added
oncall: jit
This was referenced Jun 4, 2019
zdevito
commented
Jun 4, 2019
| ActiveFrame af(frames.back()); | ||
| try { | ||
| return runInterpreterLoop(stack); | ||
| while (true) { |
Contributor
Author
There was a problem hiding this comment.
This is just moving the interpreter loop inline here because the exception handling stuff needs to see af.pc. The ops themselves, except for CALL have not meaningfully changed.
Interpreter support for CallFunction/CallMethod Summary: Adds CALL instruction, and function_table to interpreter state. Interpreter state now has a list of Frame objects to keep track of active call frames. Nodes: * Re-did how exception wrapping works so that call stacks can be printed by the interpreter. * Change the order of error reporting so that it is more clear what part of a printout is attributable to the interpreter or shape prop adding additional context to an error. * The first-class functions are only enabled under a guard because serialization does not work and more tests need to be added for the funnctionality. gh-metadata: pytorch pytorch 21325 gh/zdevito/48/head
suo
approved these changes
Jun 6, 2019
| const Code& code = | ||
| af.functions[inst.X]->get_executor().getPlanFor(stack).code; | ||
| frames.back().pc = af.pc + 1; | ||
| enterFrame(code); |
Member
There was a problem hiding this comment.
I think enterFrame and leaveFrame should set the active frame. That would require af to be a member of the interpreter state though.
| namespace torch { | ||
| namespace jit { | ||
|
|
||
| struct ExceptionMessage { |
Member
There was a problem hiding this comment.
Can you add a comment explaining what purpose this serves? Why cut out the c10 backtarce is not obvious I think.
Interpreter support for CallFunction/CallMethod Summary: Adds CALL instruction, and function_table to interpreter state. Interpreter state now has a list of Frame objects to keep track of active call frames. Nodes: * Re-did how exception wrapping works so that call stacks can be printed by the interpreter. * Change the order of error reporting so that it is more clear what part of a printout is attributable to the interpreter or shape prop adding additional context to an error. * The first-class functions are only enabled under a guard because serialization does not work and more tests need to be added for the funnctionality. gh-metadata: pytorch pytorch 21325 gh/zdevito/48/head
This was referenced Jun 7, 2019
Interpreter support for CallFunction/CallMethod Summary: Adds CALL instruction, and function_table to interpreter state. Interpreter state now has a list of Frame objects to keep track of active call frames. Nodes: * Re-did how exception wrapping works so that call stacks can be printed by the interpreter. * Change the order of error reporting so that it is more clear what part of a printout is attributable to the interpreter or shape prop adding additional context to an error. * The first-class functions are only enabled under a guard because serialization does not work and more tests need to be added for the funnctionality. gh-metadata: pytorch pytorch 21325 gh/zdevito/48/head
Interpreter support for CallFunction/CallMethod Summary: Adds CALL instruction, and function_table to interpreter state. Interpreter state now has a list of Frame objects to keep track of active call frames. Nodes: * Re-did how exception wrapping works so that call stacks can be printed by the interpreter. * Change the order of error reporting so that it is more clear what part of a printout is attributable to the interpreter or shape prop adding additional context to an error. * The first-class functions are only enabled under a guard because serialization does not work and more tests need to be added for the funnctionality. gh-metadata: pytorch pytorch 21325 gh/zdevito/48/head
Interpreter support for CallFunction/CallMethod Summary: Adds CALL instruction, and function_table to interpreter state. Interpreter state now has a list of Frame objects to keep track of active call frames. Nodes: * Re-did how exception wrapping works so that call stacks can be printed by the interpreter. * Change the order of error reporting so that it is more clear what part of a printout is attributable to the interpreter or shape prop adding additional context to an error. * The first-class functions are only enabled under a guard because serialization does not work and more tests need to be added for the funnctionality. gh-metadata: pytorch pytorch 21325 gh/zdevito/48/head
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary: Adds CALL instruction, and function_table to interpreter state.
Interpreter state now has a list of Frame objects to keep track of
active call frames.
Nodes:
by the interpreter.
part of a printout is attributable to the interpreter or shape prop
adding additional context to an error.
serialization does not work and more tests need to be added for
the funnctionality.
Differential Revision: D15618275